Python: Imports of package names with numbers get extra underscores

[mairas]

I am calling postcard_bindgen as follows:

fn main() {
    python::build_package(
        std::env::current_dir().unwrap().as_path(),
        PackageInfo {
            name: "halpi2-fw-i2c-postcard".into(),
            version: "0.1.0".try_into().unwrap(),
        },
        python::GenerationSettings::enable_all(),
        generate_bindings!(FlashUpdateCommand, FlashUpdateResponse, FlashUpdateState),
    )
    .unwrap();
}

In the resulting code, the package name is as defined but the imports get extra underscores around numbers:

from halpi_2_fw_i_2_c_postcard.types._flash_update_state import FlashUpdateState as _FlashUpdateState

Despite this, a very useful package - thank you!

[teamplayer3]

Thanks for reporting. Sorry for the delay. Will look into it.

Despite this, a very useful package - thank you!

Thanks!:)

[teamplayer3]

I search for this a little. In my code, I convert the package name into snake case. blakeembrey/change-case#50 in this issue, they say it's more common to add an underscore in front of numbers. But in your case, I understand, that you want to stick the numbers. It is difficult to find a solution fitting all. I could do my own conversion style, replacing spaces and hyphen with underscores and upper case to lower case letters. @mairas what's your opinion on that?