From 8e23de6a1fd61fada1a7726f3859da8ec1472d90 Mon Sep 17 00:00:00 2001 From: JeongHoon Lee Date: Sun, 14 Sep 2025 09:18:01 -0400 Subject: [PATCH] fix: remove profile image logics when login --- .../controller/port/MemberOnboardService.java | 1 - .../fontorybe/member/domain/Member.java | 14 -------------- .../member/domain/MemberDefaults.java | 5 +---- .../service/MemberOnboardServiceImpl.java | 18 ------------------ src/main/resources/application.properties | 2 +- .../fontorybe/unit/mock/TestContainer.java | 5 +---- 6 files changed, 3 insertions(+), 42 deletions(-) diff --git a/src/main/java/org/fontory/fontorybe/member/controller/port/MemberOnboardService.java b/src/main/java/org/fontory/fontorybe/member/controller/port/MemberOnboardService.java index 65b55e8..ee48e88 100644 --- a/src/main/java/org/fontory/fontorybe/member/controller/port/MemberOnboardService.java +++ b/src/main/java/org/fontory/fontorybe/member/controller/port/MemberOnboardService.java @@ -7,6 +7,5 @@ public interface MemberOnboardService { Member fetchOrCreateMember(Provide p); - Member initNewMemberInfo(Long requestMemberId, InitMemberInfoRequest initMemberInfoRequest, FileUploadResult fileUploadResult); Member initNewMemberInfo(Long requestMemberId, InitMemberInfoRequest initMemberInfoRequest); } diff --git a/src/main/java/org/fontory/fontorybe/member/domain/Member.java b/src/main/java/org/fontory/fontorybe/member/domain/Member.java index b7e852f..d4750ac 100644 --- a/src/main/java/org/fontory/fontorybe/member/domain/Member.java +++ b/src/main/java/org/fontory/fontorybe/member/domain/Member.java @@ -43,20 +43,6 @@ public static Member fromDefaults(MemberDefaults memberDefaults, String nickname .build(); } - public Member initNewMemberInfo(InitMemberInfoRequest initNewMemberInfo, String profileImageKey) { - return Member.builder() - .id(this.id) - .nickname(initNewMemberInfo.getNickname()) - .gender(initNewMemberInfo.getGender()) - .birth(initNewMemberInfo.getBirth()) - .createdAt(this.createdAt) - .provideId(this.provideId) - .deletedAt(this.deletedAt) - .provideId(this.provideId) - .status(MemberStatus.ACTIVATE) - .build(); - } - public Member initNewMemberInfo(InitMemberInfoRequest initNewMemberInfo) { return Member.builder() .id(this.id) diff --git a/src/main/java/org/fontory/fontorybe/member/domain/MemberDefaults.java b/src/main/java/org/fontory/fontorybe/member/domain/MemberDefaults.java index fef9010..1bdb16d 100644 --- a/src/main/java/org/fontory/fontorybe/member/domain/MemberDefaults.java +++ b/src/main/java/org/fontory/fontorybe/member/domain/MemberDefaults.java @@ -13,14 +13,11 @@ @ConfigurationProperties(prefix="member.default") public class MemberDefaults { private LocalDate birth; - private String profileImageKey; private Gender gender; @ConstructorBinding - public MemberDefaults(LocalDate birth, - String profileImageKey) { + public MemberDefaults(LocalDate birth) { this.birth = birth; - this.profileImageKey = profileImageKey; this.gender = Gender.NONE; } } diff --git a/src/main/java/org/fontory/fontorybe/member/service/MemberOnboardServiceImpl.java b/src/main/java/org/fontory/fontorybe/member/service/MemberOnboardServiceImpl.java index ec9fd37..b189b7c 100644 --- a/src/main/java/org/fontory/fontorybe/member/service/MemberOnboardServiceImpl.java +++ b/src/main/java/org/fontory/fontorybe/member/service/MemberOnboardServiceImpl.java @@ -40,24 +40,6 @@ public Member fetchOrCreateMember(Provide p) { } } - @Override - @Transactional - public Member initNewMemberInfo(Long requestMemberId, - InitMemberInfoRequest initNewMemberInfoRequest, - FileUploadResult fileUploadResult) { - Member targetMember = memberLookupService.getOrThrowById(requestMemberId); - FileMetadata fileMetadata = fileService.getOrThrowById(fileUploadResult.getId()); - if (targetMember.getStatus() == MemberStatus.ACTIVATE) { - throw new MemberAlreadyJoinedException(); - } else if (memberLookupService.existsByNickname(initNewMemberInfoRequest.getNickname())) { - throw new MemberDuplicateNameExistsException(); - } - - checkContainsBadWord(initNewMemberInfoRequest.getNickname()); - - return memberRepository.save(targetMember.initNewMemberInfo(initNewMemberInfoRequest, fileMetadata.getKey())); - } - @Override @Transactional public Member initNewMemberInfo(Long requestMemberId, diff --git a/src/main/resources/application.properties b/src/main/resources/application.properties index 64e434b..fcc6af4 100644 --- a/src/main/resources/application.properties +++ b/src/main/resources/application.properties @@ -13,7 +13,7 @@ api.server.url=http://localhost:8080 spring.config.import=optional:classpath:application-infrastructure.properties url.base=http://localhost -url.path.signup=/signup/step-one +url.path.signup=/signup url.path.auth= url.cdn=https://cdn.fontory.co.kr diff --git a/src/test/java/org/fontory/fontorybe/unit/mock/TestContainer.java b/src/test/java/org/fontory/fontorybe/unit/mock/TestContainer.java index cdf3edf..7802c19 100644 --- a/src/test/java/org/fontory/fontorybe/unit/mock/TestContainer.java +++ b/src/test/java/org/fontory/fontorybe/unit/mock/TestContainer.java @@ -15,7 +15,6 @@ import org.fontory.fontorybe.file.application.port.CloudStorageService; import org.fontory.fontorybe.file.application.port.FileRepository; import org.fontory.fontorybe.file.application.port.FileService; -import org.fontory.fontorybe.file.domain.FileUploadResult; import org.fontory.fontorybe.member.controller.MemberController; import org.fontory.fontorybe.member.controller.ProfileController; import org.fontory.fontorybe.member.controller.RegistrationController; @@ -38,7 +37,6 @@ import org.fontory.fontorybe.provide.service.port.ProvideRepository; import org.springframework.context.ApplicationEventPublisher; import org.springframework.mock.web.MockMultipartFile; -import org.springframework.web.multipart.MultipartFile; import javax.crypto.KeyGenerator; import javax.crypto.SecretKey; @@ -138,8 +136,7 @@ public TestContainer() { .build(); memberDefaults = new MemberDefaults( - LocalDate.of(1999, 12, 31), - DEFAULT_PROFILE_KEY); + LocalDate.of(1999, 12, 31)); fileService = FileServiceImpl.builder() .memberLookupService(memberLookupService)