General retry upon failure (not just 429)

[DanielYang59]

Have you checked that the enhancement does not already exist?

Yes

Summary

Guess it would be good to have a general "retry upon failure" (not just 429) feature as internet connection might have intermittent glitches and so on?

Additional context

No response

Could you implement the enhancement?

No

[mharding-hpe]

I'm not sure if this warrants a separate issue or not, but I was hoping for something like this as well, only for specific other status codes (not just 429). For example. some 5xx status codes typically indicate temporary conditions. I have some links that occasionally fail with 502s, but generally work on retry, and it would be awesome if I could just configure the link checker to automatically retry on 502s just like I can do for 429s.

I can see where it could be complicated if you have different values for number of 429 retries versus number of 502 retries, or (per the original ticket) number of overall retries. So if I were going to propose a change that would address both this ticket's request and my own use case, I'd suggest something like adding options like these 2:

retryStatusCodes which maps to a list of status codes that should be retried (and if retryOn429 is set to true, then 429 could automatically be appended to this list, if it's not in there already). And I guess that if a status code appeared in both this list and the aliveStatusCodes list, then the checker should do whatever it does currently if retryOn429 is set to true and 429 is included in the aliveStatusCodes list.
retryAllFailures which would be a boolean. If it's set to true, then it would override retryOn429 and retryStatusCodes.

Each of these would then use the same variables that are currently used for number of retries (retryCount) and the wait time (fallbackRetryDelay)

[smainil]

@mharding-hpe I will dig into the code to see how we can implement your need.

[smainil]

Sorry for the delay. Hadn't time yet to check that but you should able to have a loot into it soon

[github-actions]

This issue has been marked as stale because it has been open 60 days with no activity. It will be closed in 90 days unless the stale label is removed or someone adds a comment.

[github-actions]

This issue was closed because it has been marked as stale for 90 days with no activity.

[DanielYang59]

Emmm I forgot to add a comment, can someone reopen this? @smainil

[DanielYang59]

Thanks @tcort