Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace codecov uploader #2931

Open
ptomato opened this issue Sep 5, 2024 · 1 comment
Open

Replace codecov uploader #2931

ptomato opened this issue Sep 5, 2024 · 1 comment
Labels
tools Tools for managing this repo

Comments

@ptomato
Copy link
Collaborator

ptomato commented Sep 5, 2024

We use codecov.io to see how much of the reference code is covered by test262, in order to get information on where there might be testing gaps.

Already several years ago, codecov.io has ended support for a bunch of their uploader packages, including codecov-node, the one we use: https://about.codecov.io/blog/codecov-uploader-deprecation-plan/

codecov-node still works for the time being. I was afraid that it had stopped working when the codecov.io upload started failing on PRs, but luckily that was solved by upgrading from 3.8.2 to 3.8.3, the very last version. However, since the package is unsupported, it will probably continue to bitrot and stop working eventually.

We should migrate to use codecov.io's GitHub Action, as described here: https://docs.codecov.com/docs/codecov-uploader

@ptomato ptomato added the tools Tools for managing this repo label Sep 5, 2024
@ljharb
Copy link
Member

ljharb commented Sep 5, 2024

I'd suggest sticking to v3.1.5 of the codecov action, since v4 requires a token, and ^3.1.6 doesn't work on node 20.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Tools for managing this repo
Projects
None yet
Development

No branches or pull requests

2 participants