Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Behavior of [[Get]] and [[Set]] not specified #39

Closed
waldemarhorwat opened this issue Oct 7, 2024 · 7 comments · Fixed by #40
Closed

Behavior of [[Get]] and [[Set]] not specified #39

waldemarhorwat opened this issue Oct 7, 2024 · 7 comments · Fixed by #40

Comments

@waldemarhorwat
Copy link

The proposal currently changes the signature of [[Get]] and [[Set]] in some but not all places in the spec which makes the spec self-inconsistent. I can't tell what the intended behavior of [[Get]] and [[Set]] calls is in the unchanged places.

@syg
Copy link
Collaborator

syg commented Oct 7, 2024

For the unsafe blocks? The intention is that the default value to the unsafe parameter is false. @rbuckton to confirm.

Edit: that is, the intention is that the behavior of existing [[Get]] and [[Set]] calls in the spec today are unchanged.

@rbuckton
Copy link
Collaborator

rbuckton commented Oct 8, 2024

The intent is that [[Get]] and [[Set]] maintain their current behavior. I did attempt to cover all cases of [[Get]] and [[Set]] in the spec, though it does look like I missed a description for the parameter and its meaning in "6.1.7 The Object Type". I do have it specified for ordinary objects, Arguments exotic objects, TypedArray exotic objects, module namespace exotic objects, and proxies. Is there anywhere else I missed, or just in 6.1.7?

@rbuckton rbuckton closed this as completed Oct 8, 2024
@rbuckton
Copy link
Collaborator

rbuckton commented Oct 8, 2024

Or do you mean invocations of [[Get]]/[[Set]]? If so yes, there are a number of those that are not included as of yet, but the expectation is that false would be passed. This would be addressed more thoroughly in the final spec draft prior to Stage 2.7/3.

@rbuckton rbuckton reopened this Oct 8, 2024
@rbuckton
Copy link
Collaborator

rbuckton commented Oct 8, 2024

Sorry, didn't mean to close this.

@waldemarhorwat
Copy link
Author

Yes, I meant invocations of [[Get]] and [[Set]]. I couldn't tell what was intended there.

@rbuckton
Copy link
Collaborator

rbuckton commented Oct 8, 2024

For now, I can add a NOTE to indicate the intention.

@rbuckton
Copy link
Collaborator

rbuckton commented Oct 8, 2024

I've added the following note in #40 to address these call sites:

Image

Given the entrance criteria in the process document, this should hopefully be acceptable for Stage 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants