Skip to content

Commit 7dc5cb7

Browse files
committed
Quote some logged strings
Now, that auto-quoting is disabled in the log, let's quote server names and conditions because without quoting they look ugly. No changelog as this is a minor change related to the previous commit.
1 parent fa14308 commit 7dc5cb7

File tree

2 files changed

+14
-14
lines changed

2 files changed

+14
-14
lines changed

luatest/replica_set.lua

+4-4
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ function ReplicaSet:initialize()
7272
else
7373
self.servers = {}
7474
end
75-
log.info('Replica set %s initialized', self.id)
75+
log.info('Replica set %q initialized', self.id)
7676
end
7777

7878
--- Build a server object for the replica set.
@@ -148,7 +148,7 @@ function ReplicaSet:delete_server(alias)
148148
if server_index then
149149
table.remove(self.servers, server_index)
150150
else
151-
log.warn('Server %s does not exist in replica set %s', alias, self.id)
151+
log.warn('Server %q does not exist in replica set %q', alias, self.id)
152152
end
153153
end
154154

@@ -174,7 +174,7 @@ function ReplicaSet:start(opts)
174174
server:wait_until_ready()
175175
end
176176
end
177-
log.info('All servers started in replica set %s', self.id)
177+
log.info('All servers started in replica set %q', self.id)
178178
end
179179

180180
--- Stop all servers in the replica set.
@@ -236,7 +236,7 @@ function ReplicaSet:wait_for_fullmesh(opts)
236236
end
237237
end
238238
end, self)
239-
log.info('Full mesh is ready in replica set %s', self.id)
239+
log.info('Full mesh is ready in replica set %q', self.id)
240240
end
241241

242242
return ReplicaSet

luatest/server.lua

+10-10
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ function Server:new(object, extra)
127127
if not object.tests[t.name] then
128128
object.tests[t.name] = t
129129
t.servers[object.id] = object
130-
log.info('Server %s used in %s test', object.alias, t.name)
130+
log.info('Server %q used in %s test', object.alias, t.name)
131131
end
132132
end
133133
return v(...)
@@ -461,7 +461,7 @@ function Server:start(opts)
461461
self:wait_until_ready()
462462
end
463463

464-
log.info('Server %s (pid: %d) started', self.alias, self.process.pid)
464+
log.info('Server %q (pid: %d) started', self.alias, self.process.pid)
465465
end
466466

467467
--- Restart the server with the given parameters.
@@ -495,7 +495,7 @@ function Server:restart(params, opts)
495495
}, {wait_until_ready = '?boolean'})
496496

497497
if not self.process then
498-
log.warn('Cannot restart server %s since its process not started', self.alias)
498+
log.warn('Cannot restart server %q since its process not started', self.alias)
499499
end
500500
self:stop()
501501

@@ -504,7 +504,7 @@ function Server:restart(params, opts)
504504
end
505505

506506
self:start(opts)
507-
log.info('Server %s (pid: %d) restarted', self.alias, self.process.pid)
507+
log.info('Server %q (pid: %d) restarted', self.alias, self.process.pid)
508508
end
509509

510510
-- Save server artifacts by copying the working directory.
@@ -513,7 +513,7 @@ end
513513
-- following string: `Failed to copy artifacts for server (alias: <alias>, workdir: <workdir>)`.
514514
function Server:save_artifacts()
515515
if self.artifacts_saved then
516-
log.info('Artifacts of server %s already saved to %s', self.alias, self.artifacts)
516+
log.info('Artifacts of server %q already saved to %s', self.alias, self.artifacts)
517517
return
518518
end
519519
local ok, err = fio.copytree(self.workdir, self.artifacts)
@@ -522,15 +522,15 @@ function Server:save_artifacts()
522522
:format(self.alias, fio.basename(self.workdir))
523523
log.error(('%s: %s'):format(self.artifacts, err))
524524
end
525-
log.info('Artifacts of server %s saved from %s to %s',
525+
log.info('Artifacts of server %q saved from %s to %s',
526526
self.alias, self.workdir, self.artifacts)
527527
self.artifacts_saved = true
528528
end
529529

530530
-- Wait until the given condition is `true` (anything except `false` and `nil`).
531531
-- Throws an error when the server process is terminated or timeout exceeds.
532532
local function wait_for_condition(cond_desc, server, func, ...)
533-
log.info('Wait for %s condition for server %s (pid: %d) within %d sec',
533+
log.info('Wait for %q condition for server %q (pid: %d) within %d sec',
534534
cond_desc, server.alias, server.process.pid, WAIT_TIMEOUT)
535535
local deadline = clock.time() + WAIT_TIMEOUT
536536
while true do
@@ -559,7 +559,7 @@ function Server:stop()
559559
self:coverage('shutdown')
560560
end
561561
self.net_box:close()
562-
log.info('Connection to server %s (pid: %d) closed', self.alias, self.process.pid)
562+
log.info('Connection to server %q (pid: %d) closed', self.alias, self.process.pid)
563563
self.net_box = nil
564564
end
565565

@@ -582,7 +582,7 @@ function Server:stop()
582582
error(('Memory leak during process execution (alias: %s, workdir: %s, pid: %s)\n%s')
583583
:format(self.alias, workdir, pid, stderr))
584584
end
585-
log.info('Process of server %s (pid: %d) killed', self.alias, self.process.pid)
585+
log.info('Process of server %q (pid: %d) killed', self.alias, self.process.pid)
586586
self.process = nil
587587
end
588588
end
@@ -895,7 +895,7 @@ function Server:grep_log(pattern, bytes_num, opts)
895895
return rawget(_G, 'box_cfg_log_file') or box.cfg.log end)
896896
local file = fio.open(filename, {'O_RDONLY', 'O_NONBLOCK'})
897897

898-
log.info('Trying to grep %s in server\'s log file %s', pattern, filename)
898+
log.info('Trying to grep %q in server\'s log file %s', pattern, filename)
899899

900900
local function fail(msg)
901901
local err = errno.strerror()

0 commit comments

Comments
 (0)