roles: change server address after reload

If the `listen` value was changed the server won't update it after
config reload.

After the patch this bug was fixed.

Closes #209

Author: themilchenko

CHANGELOG.md

@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Fixed
 
 - Removing the server if it is not in use (#212).
+- Changing server address if it was edited (#209).
 
 ## [1.7.0] - 2024-11-15
 

roles/httpd.lua

@@ -99,6 +99,10 @@ local function apply_http(name, node)
             httpd = httpd,
             routes = {},
         }
+    elseif servers[name].host ~= host or servers[name].port ~= port then
+        servers[name].httpd:stop()
+        servers[name].httpd = http_server.new(host, port, parse_params(node))
+        servers[name].httpd:start()
     end
 end
 

test/integration/httpd_role_test.lua

@@ -129,3 +129,20 @@ g.test_stop_server_after_remove = function(cg)
 
     t.assert_not(helpers.tcp_connection_exists('localhost', 13001))
 end
+
+g.test_change_server_addr_on_the_run = function(cg)
+    local resp = http_client:get('http://0.0.0.0:13001/ping')
+    t.assert_equals(resp.status, 200, 'response not 200')
+    t.assert_equals(resp.body, 'pong')
+
+    local cfg = table.deepcopy(config)
+    cfg.groups['group-001'].replicasets['replicaset-001'].roles_cfg['roles.httpd'].additional.listen = 'localhost:13001'
+    treegen.write_file(cg.server.chdir, 'config.yaml', yaml.encode(cfg))
+    local _, err = cg.server:eval("require('config'):reload()")
+    t.assert_not(err)
+
+    t.assert_not(helpers.tcp_connection_exists('0.0.0.0', 13001))
+    resp = http_client:get('http://localhost:13001/ping')
+    t.assert_equals(resp.status, 200, 'response not 200')
+    t.assert_equals(resp.body, 'pong')
+end

test/unit/httpd_role_test.lua

@@ -291,3 +291,23 @@ g.test_stop_unusable_servers = function()
     t.assert(httpd_role.get_server())
     t.assert_equals(httpd_role.get_server('additional'))
 end
+
+g.test_edit_server_address = function()
+    local cfg = {
+        [httpd_role.DEFAULT_SERVER_NAME] = {
+            listen = 13001,
+        },
+    }
+
+    httpd_role.apply(cfg)
+    local result = httpd_role.get_server()
+    t.assert(result)
+    t.assert_equals(result.port, cfg[httpd_role.DEFAULT_SERVER_NAME].listen)
+
+    cfg[httpd_role.DEFAULT_SERVER_NAME].listen = 13002
+
+    httpd_role.apply(cfg)
+    result = httpd_role.get_server()
+    t.assert(result)
+    t.assert_equals(result.port, cfg[httpd_role.DEFAULT_SERVER_NAME].listen)
+end