PHP7 Delegation

Author: Dominik Liebler

More/Delegation/JuniorDeveloper.php

@@ -4,7 +4,7 @@
 
 class JuniorDeveloper
 {
-    public function writeBadCode()
+    public function writeBadCode(): string
     {
         return 'Some junior developer generated code...';
     }

More/Delegation/README.rst

@@ -23,12 +23,6 @@ Code
 
 You can also find these code on `GitHub`_
 
-Usage.php
-
-.. literalinclude:: Usage.php
-   :language: php
-   :linenos:
-
 TeamLead.php
 
 .. literalinclude:: TeamLead.php

More/Delegation/TeamLead.php

@@ -4,26 +4,21 @@
 
 class TeamLead
 {
-    /** @var JuniorDeveloper */
-    protected $slave;
+    /**
+     * @var JuniorDeveloper
+     */
+    private $junior;
 
     /**
-     * Give junior developer into teamlead submission.
-     *
      * @param JuniorDeveloper $junior
      */
     public function __construct(JuniorDeveloper $junior)
     {
-        $this->slave = $junior;
+        $this->junior = $junior;
     }
 
-    /**
-     * TeamLead drink coffee, junior work.
-     *
-     * @return mixed
-     */
-    public function writeCode()
+    public function writeCode(): string
     {
-        return $this->slave->writeBadCode();
+        return $this->junior->writeBadCode();
     }
 }

More/Delegation/Tests/DelegationTest.php

@@ -4,15 +4,13 @@
 
 use DesignPatterns\More\Delegation;
 
-/**
- * DelegationTest tests the delegation pattern.
- */
 class DelegationTest extends \PHPUnit_Framework_TestCase
 {
     public function testHowTeamLeadWriteCode()
     {
         $junior = new Delegation\JuniorDeveloper();
         $teamLead = new Delegation\TeamLead($junior);
+
         $this->assertEquals($junior->writeBadCode(), $teamLead->writeCode());
     }
 }