Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Material3 in the ui module #26

Open
vanniktech opened this issue Nov 26, 2024 · 4 comments
Open

Use Material3 in the ui module #26

vanniktech opened this issue Nov 26, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@vanniktech
Copy link

The ui module is currently still using the material library and not the material3 library. Is there any particular reason for this? I'm using material3 in my app and therefore I can't quite use the proper colors using my Theme since they aren't compatible.

@tamimattafi
Copy link
Owner

Hello @vanniktech !
The old fork used these dependencies, so we kept them while porting to KMP.
If you need material3, we can introduce it as a separate module in the upcoming versions.

@tamimattafi tamimattafi added the enhancement New feature or request label Nov 26, 2024
@vanniktech
Copy link
Author

I've started adopting this library for my new project. I've noticed some more things. In the meantime I've used the parameter for specifying the TopBar and that fixes my issue regarding styling for now.

This library has a huge potential, I think we would need to work out some tweaks though. #24 is already a nice step. Do you need a review or what is holding it back from being merged?

@vanniktech
Copy link
Author

#28 & #27 are my main pain points, everything else can be worked around.

@tamimattafi
Copy link
Owner

@vanniktech A review for #24 would be great! I just need to test the changes more before merging. But since I'm on a vacation now, I have very limited access to my pc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants