Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

snapshot use directio, which is not supported by tmpfs #349

Open
oocococo opened this issue Dec 16, 2021 · 1 comment
Open

snapshot use directio, which is not supported by tmpfs #349

oocococo opened this issue Dec 16, 2021 · 1 comment

Comments

@oocococo
Copy link
Contributor

While applying snapshot, https://github.com/Connor1996/badger will try to invoke directio.OpenFile

However, directio is not supported by linux tmpfs issue1 issue2, which is the default storage location of tinykv test.
It will block forever while apply snapshot.

I think maybe we can fallback from directio.OpenFile to os.OpenFile when O_DIRECT is not supported.
@oocococo oocococo mentioned this issue Dec 16, 2021
Merged
@Connor1996
Copy link
Collaborator

Merge the PR, please update badger dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Connor1996 @oocococo