Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify support for other storage options #5

Open
sbuettner opened this issue Apr 29, 2016 · 1 comment
Open

Simplify support for other storage options #5

sbuettner opened this issue Apr 29, 2016 · 1 comment

Comments

@sbuettner
Copy link
Contributor

sbuettner commented Apr 29, 2016

The two new resources under the /storage/v1/diag path which are provided by the StatusStorageResource and TreeStorageResource implementations make strong assumptions about the storage system in use since they only use the folderPath of the configured filesystem. Before the introduction of these resources it was quite easy to add support for other storage options (S3 for example).

Would it be possibly to provide an abstraction that might be used by the resources under /storage/v1/diag to allow other storage options? I was thinking about something like a DiagnosticService interface which could be implemented for other storage options.

Cheers

@chook
Copy link
Contributor

chook commented Jun 30, 2016

Before we introduce an interface refactor it is possible to just NOP the two diagnostics resources StatusStorageResource.java can return only the collectMachineInfo part and TreeStorageResource.java can just return an empty string "".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants