Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document BasechainAddress struct and related functions #2044

Closed
6 tasks
novusnota opened this issue Feb 26, 2025 · 4 comments · Fixed by #2411
Closed
6 tasks

Document BasechainAddress struct and related functions #2044

novusnota opened this issue Feb 26, 2025 · 4 comments · Fixed by #2411
Assignees
@i582
Labels
docs: Reference /ref section of the docs: API reference, standard libraries, specification and evolution kind: docs Documentation for docs.tact-lang.org kept in docs folder
Milestone
v1.6.4

Comments

@novusnota
Copy link
Member

novusnota commented Feb 26, 2025 •
edited by anton-trunov
Loading

Introduced in #2035. It had some doc comments, but not the documentation itself.

  • struct BasechainAddress (available since 1.6.0)
  • emptyBasechainAddress (available since 1.6.0)
  • newBasechainAddress (available since 1.6.0)
  • contractBasechainAddress (available since 1.6.0)
  • storeBasechainAddress (available since 1.6.0)
  • add the new functions to CHANGELOG
@novusnota novusnota added docs: Reference /ref section of the docs: API reference, standard libraries, specification and evolution kind: docs Documentation for docs.tact-lang.org kept in docs folder labels Feb 26, 2025
@novusnota novusnota added this to the Doc: 2025-02 milestone Feb 26, 2025
@novusnota novusnota self-assigned this Feb 26, 2025
@novusnota novusnota modified the milestones: Doc: 2025-02, v1.6.0 Feb 26, 2025
@novusnota novusnota mentioned this issue Mar 3, 2025
Merged
4 tasks
@novusnota
Copy link
Member Author

Add docs for #2097 too.

@novusnota novusnota modified the milestones: Doc: 2025-02, Doc: 2025-03 Mar 8, 2025
@novusnota novusnota mentioned this issue Mar 10, 2025
Merged
@novusnota
Copy link
Member Author

And a new suggestion on the gas best practices page (#2342)

@anton-trunov anton-trunov pinned this issue Mar 13, 2025
@novusnota
Copy link
Member Author

novusnota commented Mar 14, 2025 •
edited
Loading

Needs #2391. Until then, I'll be completing #2375.

UPD: Ok, this is unblocked, doing it quickly.
UPD: I'll send PR in the morning — turns out we didn't add the respective load/skip functions for Slices when introducing the Builder.storeBasechainAddress function. That needs to change, which is why I've added this to the 1.6.4 milestone.

@novusnota novusnota modified the milestones: Doc: 2025-03, v1.6.4 Mar 16, 2025
@novusnota novusnota mentioned this issue Mar 17, 2025
Draft
@anton-trunov
Copy link
Member

No new functionaly in PRs fixing things please

@anton-trunov anton-trunov assigned i582 and unassigned novusnota Mar 18, 2025
i582 added a commit that referenced this issue Mar 18, 2025
@i582
feat(docs): add documentation for basechain address related struct an…
1f60d2e 
…d functions

- `BasechainAddress`
- `emptyBasechainAddress`
- `newBasechainAddress`
- `contractBasechainAddress`
- `storeBasechainAddress`

Fixes #2044
@i582 i582 mentioned this issue Mar 18, 2025
Merged
@anton-trunov anton-trunov unpinned this issue Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@i582 i582

Labels
docs: Reference /ref section of the docs: API reference, standard libraries, specification and evolution kind: docs Documentation for docs.tact-lang.org kept in docs folder
Projects
None yet
Milestone
v1.6.4
Development

Successfully merging a pull request may close this issue.

feat(docs): add documentation for basechain address related struct and functions tact-lang/tact
3 participants
@anton-trunov @i582 @novusnota