Fork updates from ycm-core/YouCompleteMe master #32

Previously we would trigger completion (call complete()) on every keystroke even if nothing had changed in the result set. The purpose of this with the old completion system (using feedkeys) was to reduce flicker - we closed the completion menu on every keystroke, then re-opened it. With the new completion system, that's not necessary as we don't close the pum on every keystroke - only when the result set is emtpy. However, we still called complete() on every keystroke to ensure that it's always our own filtering etc. that gets applied. The problem with this is that this causes a _lot_ of redraw. Every call to complete() seems to involve a very expensive draw call, particularly in languages with complex regex-based syntax highlighting. Profiling vim suggests that this change roughly halves the time spend redrawing - which is to be expected. I think that the extremely slow redraw is a bug in either the syntax file or vim itslef, frankly, but this is quite difficult to pin down. For now, I think it's better to have occasionally-incorrect filtering when deleting characters to frequently-extremely-laggy typing.

This is more of an issue now that we echo diags inline - previously we were updating the echo'd (or virtual text) diagnostic even if diag updates were disabled in insert mode. This was annoying. OnCursorMoved is called for both normal and insert mode, so just don't update in insert mode. Also clear virtual text when going into insert moode if updates are disabled. This feels really nice to work with, by comparison with all the noise when it's enabled, so recommend that setting in the docs. Perhaps we can in future make it the default.

only clear the range that we actually received add a <plug> mapping to toggle them on/off manually. add an option to enable/disable in insert mode

Inlay hints

When available use the "types" list in prop_remove

Reduce calls to prop_remove

… When text is inserted it can easily just be wrong and tracking the changes is monstrously complex

Inlay hints: Stop trying to be clever about clearing the right range.…

For some reason, the (wierd) way we were initialising s:enable_inlay_hints via vim.command was causing wierdness on older vims and neovim (i.e. where it was returning 0). Unclear why this was happening, but using less wierd syntax seems to fix it.

…-issue Fix passing '+10' etc on command line in older vims.

If a candidate shown in the symbol finder is too long to display the path and line number, we would incorrectly calculate the length of the path text property. Calculate it correctly.

Fix traceback when a long identifier is displayed in finder

Update ycmd : update jdtls

Fixes #4059

Fix cursorlineopt

Fixes #4069

> Merge pull request #1658 from puremourning/update-clang-15 > Merge pull request #1657 from puremourning/update-third-party

Update ycmd

Recent vims validate that you can't supply end_lnum/end_col with a text property, so don't supply them.

Auto update vim docs

Typo

Fix 2 minor typos in README

Fix typo in README

[Auto] Update vim docs

Document 'FixIt' capability to refactor

[Auto] Update vim docs

When automatic triggering is disabled, we now set the completefunc, so the user can use C-x C-u. We also provide a plug mapping that does the completion as users may not be comfortable with c-x c-u. As this is a very unusual use-case for YCM we sweep under the rug that most users probably want to use <Tab> for both completion and "next". Or perhaps want to use C-p in the same way. For now a unique mapping works.

Provide a way to manually trigger YCM's completions

[Auto] Update vim docs

@gdams

thanks @gdams

Update ycmd

[Auto] Update vim docs

Accept invalid end_lnum field in diagnose parse

Hide diags in insert mode

This fixes the behavour of GoToAlternate file to keep the buffer's cursor position.

…-file-only-goto Don't change the cursor position if GoTo doesnt have one

Update ycmd

[Auto] Update vim docs

Fixes #4125

Fix traceback when diagnostics contain quotes

Use vim packages

[Auto] Update vim docs

Use macOS 12 in CI

Fix mergify for macos 12

Add the ability to pass popup_params when creating a custom ycm_hover

Yet more attempts to catch 'changedtick' returning ''

[Auto] Update vim docs

…ck for... sometimes

Update to clang 16.0.1

…indow number for getting the location lists

Fix traceback in neovim when changin tabs; use WindowID rather than w…

Re-use the "optimal range" drawing used by inlay hints, i.e. only re-request if the new visible range is not covered by the previously requested visible range. Essentially, semantic highlighting and inlay hints now use the (almost) exact same code. Still TODO (for both): record the _actual_ received range and compare against that. The point is that we should only redraw if the new range isn't within the last _drawn_ range. This is important for semantic highlighting because servers might not support range highlighting and we should therefore paint the whole buffer and only re-do that when it changes.

This means that if the servers return a wider range of semantic tokens or inlay hints than we requested, we don't constantly re-request them whenever the viewport moves. Importantly, clangd doesn't support range tokens, so we previously requested and re-parsed, deleted and re-added every single token on every single scroll event. This meant that scrolling was very slow and lots of wasted effort. This should help reduce that. We should essentially re-use the tokens on scolling and pretty much never re-request them unless the buffer changes or we have a file-ready-to-parse.

Clangd now includes all stdlib stuff by default in the initial search, so we sometimes match random stdlib symbols. Make the symbols we search for a little more unique by prefixing with x

…n't crash etc.

…misation Semantic highlighting optimisation

[Auto] Update vim docs

…n startup

Just apply the mods to the pedit command.

Accept command modifiers (mods) for GetDoc subcommand

[Auto] Update vim docs

Use execute() rather than redir to avoid clearing the splash screen o…

We were supposed to allow users to set highlight groups for any token types that we don't understand, as servers can basically return anything they like. This didn't work and we just always complained about it. Now we trap the "text property type doesn't exist" error and warn then. This allows users to specify the missing ones to stfu the error. Also improved the message to point to the help.

…lighting Fix custom text properties for semantic highlighting

* Fixes spelling errors * Fixes grammar errors

Add option to disable signature help syntax highlights

Fix typos in readme

[READY] Update all actions

…popup This seems to work, but I have a few questions - What tests should I look at to understand how to write one for this change? - Are you happy with the name `YcmErrorPopup`? - What should I set as `'priority'`, `'combine'`, `'override'`?

Fixes #4182

Replace tabs with spaces when echoing a message

Address #4165: provide a highlight group for the detailed diagnostic popup

[Auto] Update vim docs

Update setup-java action

Mostly completer upgrades, and we are now python 3.12 ready.

Update to new ycmd

First and more common error is that by the time we execute buffer = vim.buffers[ bufnr ] the buffer might not be there any more. This is because `RangeVisibleInBuffer()` is called asynchronously and the user may bwipeout a buffer in between polls. This regularly happens in our vim tests. In such a case, we get a nasty traceback from `vimsupport` module. The solution is to catch the KeyError and return None. However, `ScrollingBufferRange()` also was not ready to handle None values from `RangeVisibleInBuffer()`, even though `RangeVisibleInBuffer()` could return None even before, if a visible window for `bufnr` can not be found.

…buffer Handle possible errors from RangeVisibleInBuffer()

…sert_mode == 0 Needed settings: let g:ycm_update_diagnostics_in_insert_mode = 0 let g:ycm_echo_current_diagnostic = 'virtual-text' Previously, whenever we should NOT display diagnostic UI, but diag message would not need clearing, we ended up echoing. Most noticable in the following example int main() { puts("")<CR> } Note that this first patch still leaves a diagnostic UI flicker on InsertLeave.

In case the current filetype language server uses LSP async diagnostics, we might not get a reparse on InsertLeave. This happens if the user leaves insert mode after a semantic trigger. We would still try sending a FileReadyToParse request, but the diags get ignored, because: a) The filetype is known to use async diags. b) We do not insist on a synchronous diag update, like :YcmDiags. The solution is to check if the current filetype uses async diagnostics and, if so, let InsertLeave refresh diagnostic UI regardless of what the state of FileReadyToParse request is. Note that this solution makes the flicker on leaving insert mode harder to fix. Not only does OnCursorMoved cause a refresh of stale diagnostics, but so does OnInsertLeave.

Diagnostics fixes - hopefully only the non-controversial parts

[Auto] Update vim docs

Broken by ycm-core/ycmd#1720 - Add diagnostic type to output Inexplicable syntax errors Missing semantic_highlighting groups lead to unexpected output Improve diagnostic test failure messages - print the popup positions

Add instructions for use with .NET 6.0

[Auto] Update vim docs

Previously GetTextPropertyForDiag() assumed it was dealing with a single-line diagnostic. For multiline diagnostics we have three additional cases: - From start of the diagnostic to the end of the line. - Happens on the first line of diagnostic. - From start of the line to the end of the diagnostic. - Happens on the last line of diagnostic. - Whole line - Happens between first and last line of diagnostic.

Diagnostic interface used to store multiline diags only on thte starting line. With this pull commit, _line_to_diags stores a multiline diagnostic for each line in the range `diag['range']['start'/'end'].

[READY] Properly handle diag text property length in multiline diags

…andidate To play nice with some other plugins, we only trigger completion if the cursor has not moved between making a request and displaying the results. Previous oversight led to being unable to switch to semantic completion after selecting an identifier completer candidate that changes the cursor position. The fix is to update the last cursor position from which the completion request was made when the user hits <C-Space>

Make switching to semantic completer work after select ID completer candidate

Fixes spelling and grammar errors

Previously len( desc ) and len( path ) counted bytes, which was wrong for non-ascii characters. A string like `čđš` should have the length of 3 when calculating the number of spaces between the identifier and the file path. That brings us to choosing the right string length function. The choices are: - strcharlen - counts grapheme clusters. `čđš` is 3, `čđ\tš` is 4. - strdisplaywidth - counts character width on screen. `čđš` is 3 and `čđ\tš` is 9 (assuming `tabstop` is 8). Tabs do not appear in identifier names, but double width emojis might? Tabs *can* appear in file names though. If there's more than one tab in the file name, using `strcharlen` will push the file path text off screen.

Fix display of special characters in finder popups

Previously, we have always used the diagnostics start column of the *starting* line of a multiline diagnostic. This is wrong, as the starting column for a line in the middle of a multiline diagnostic is always 1. Previous patch just happens to work if the start column of the first line of the diagnostic is also 1.

…ctric-boogaloo [READY] Take care of start column in multiline diags for detailed diag popups

If a line for which detailed diagnostics are requested contains more than a single diagnostic with the same message, YCM will try `options.pop( 'col' )` more than once. We do not need to really iterate through the diagnostics once we have found the first one that is a match. If there's only one diag with the matching message, looping beyond that diagnostic is just a waste of time. If there's multiple diagnostics with the same message, it does not matter which one we display in the popup. Hence, the added break at the end of the loop.

…f-the-sith [READY] Handle multiple identical diagnostics in YcmShowDetailedDiagnostic popup

This was only for autoload/youcompleteme.vim

Correct a few typos in comments

[READY] Stop auto hover timer if buffer changes or cursor moves

There are two kinds of scrolling that need to be handled: 1. Scrolling the buffer in a window shifts the buffer, but popups stay in place. Instead, we close the popup whenever we receive a WinScrolled event. 2. Scrolling the popup contents themselves resets the `updatetime` timer and can trigger a second CursorHold event, which leads to YCM resetting the hover popup. Instead, only re-display the hover popup if it is not already visible.

[READY] Handle scrolling when hover popup is open

Changes since the last update: ycm-core/ycmd#1728 YcmShowDetailedDiagnostic should now match what is echoed on the command line. ycm-core/ycmd#1731 Add support for `workspace/didChangeWorkspaceFolders` LSP notification. ycm-core/ycmd#1730 LSP servers are now updated with latest server state afer reset ycm-core/ycmd#1727 Update JDT to version 1.31.0 ycm-core/ycmd#1726 C# symbol search filtering fix ycm-core/ycmd#1724 C# GoToDocumentOutline consistency patch ycm-core/ycmd#1723 Implement GoToDocumentOutline in C# ycm-core/ycmd#1716 Display tsserver tags in detailed info and GetDoc `workspace/didChangeWorkspaceFolders` seems to be working fine for java, rust and go, but should be considered experimental. Definitely more field experience is needed. What it should do is allow LSP servers to understand multiple projects in the same vim instance.

[READY] Fix tests after ycmd update

Remove extra backtick

[Auto] Update vim docs

This makes the popup disappear if you keep typing or enter inser mode or move the cursor etc. I found it jarring that previously it would just move the cursor behind the popup and such until you hit escape. Makes the popup more "modal" but without actually stopping you from continueing. Also: - Use simliar up/down keys as the symbol finder (c-p, c-k, c-n, c-j etc.) - SetupFoo -> SetUpFoo because the verb is "To set up" (rather than the noun "a setup". - purge barbaric 80+ character lines

We try to be a bit consistent with the finder poppup, but implementation-wise this is simpler. The idea is that there are 3 columns, each having 1/3 of the popup width. We fix the width of the popup (like we do for the finder) and set the tabstop to 1/3 of the internal width (core_width). Then when displaying text, we truncate "columnns" according to that tabstop (to avoid mess). To do this, we pass structured data from the python layer to vimscript and construct the line text there. This will also help later when we add in the syntax highlight (text properties) like we have for the finder popup.

This basically involves moving the properties mapping to its own place, and creating text properties to overlap the various parts of the popup columns. Style matches, and feels correct. Fiddly part is that we have to (for some reason) set cursorline every time we move the cursor, but ain't nobody gonna be able to explain why, and why that only necessary after launching the finder popup window once. Some wierd vim bug is my guess.

This makes the columns seem less broken, particularly for leading whitespace. This is particularly problematic due to our use of tabstop: if the leading whitespace was a tab, it would go nuts. It would still go nuts for any other literal tab in the description. Perhaps we should fix that too.

…resizing

Previously, when changing direction of hierarchy and re-rooting the hierarchy tree, we would retain the old node as the new root. That works most of the time, but fails in the face of multiple inheritance and switching to supertypes. In that, problematic, case, the resulting hierarchy will be missing some supertypes. Worse, if a call hierarchy contains a node with multiple locations, re-rooting to that node behaved in a way that defies explanation. The solution is to throw away everything and start a new hierarchy completely every time a user requests re-rooting. This trades some performance for correctness, but this is not at all performance sensitive.

In order to send a ycmd request for an unloaded buffer one must first... load the buffer. That is the only way to reliably determine the buffer's filetype. However, we do not want to switch to the buffer, so everything needs to be done "in the background". `:badd` adds a buffer as unloaded, if it were not present before. `bufload()` loads a buffer that has previously not been loaded.

Previously all new nodes were counted as 1. With call hierarchies, there may be more locations/lines per hierarchy node. In that case, the cursorline would be set to the wrong line. Instead, we need to add up the lengths of all the item locations.

Changelog: 1. Upgrade all subservers 2. Hierarchy support

Previously the tests were using async result checking, but this is intended for insert mode only. In fact we were running off the end of the test and then the check callbacks were firing. Simplified by just making it the same but sequential, and replacding FeedAndCheck* with direct calls to feedkeys(..., 'xt').

indexof was added so recently that even vim-helptag-versions website doesn't have it. Replace with a loop.

There were some unnecessary `WaitForAssert()` calls and unnecessary `silent` commands.

- `badd` is unnecessary since we have `GetBufferNumberForFilename()` - Instead of passing `location`, we can pass `file`, `line` and `column` separately.

[READY] Implement type/call hierarchy handling

[Auto] Update vim docs

The `decorator` type was introduced in LSP 1.17. The `concept` type is used by clangd.

Add new semantic token types

The given repository is no longer needed to install the specified packages.

Update ycmd submodule

Since Ubuntu 24.04 is out, we can clean up a bit. Some of the `VimSupportsFoo()` functions will always return `True` in vim, but we also need to take into account othervim.

coverage and click were pinned because covimerage was outdated. Now covimerage states its dependencies properly and works with coveragepy 7.

[Auto] Update vim docs

Since vim 9.1.0469, completeopt is a global-local option. When adding `noselect`, we need to treat `completeopt` as local and use `setlocal`. This works for 9.1.0016 as well and allows users to freely mess with buffer-local `completeopt` without messing up YCM completions.

[READY] Use setlocal for temporary completeopt adjustment

Fix typos in the code of conduct document

Commits on Feb 21, 2023

Use macOS 12 in CI

puremourning committed Feb 21, 2023

Configuration menu

View commit details

Copy full SHA for 915fc22

Browse repository at this point

Copy the full SHA

915fc22 View commit details

Browse the repository at this point in the history

Commits on Sep 13, 2023

Update setup-java action

bstaletic committed Sep 13, 2023

Configuration menu

View commit details

Copy full SHA for d40e1ef

Browse repository at this point

Copy the full SHA

d40e1ef View commit details

Browse the repository at this point in the history

Commits on Dec 23, 2023

Merge branch 'master' into patch-1

H4ppy-04 authored Dec 23, 2023

Configuration menu

View commit details

Copy full SHA for c28772a

Browse repository at this point

Copy the full SHA

c28772a View commit details

Browse the repository at this point in the history

Commits on May 17, 2024

flake8

bstaletic committed May 17, 2024

Configuration menu

View commit details

Copy full SHA for 9d8d267

Browse repository at this point

Copy the full SHA

9d8d267 View commit details

Browse the repository at this point in the history

Commits on Aug 7, 2024

Update CI config

bstaletic committed Aug 7, 2024

Configuration menu

View commit details

Copy full SHA for 5d8a7fe

Browse repository at this point

Copy the full SHA

5d8a7fe View commit details

Browse the repository at this point in the history

Commits on Aug 25, 2024

Update ycmd submodule

msteffen committed Aug 25, 2024

Configuration menu

View commit details

Copy full SHA for 7f0ef0e

Browse repository at this point

Copy the full SHA

7f0ef0e View commit details

Browse the repository at this point in the history

Fork updates from ycm-core/YouCompleteMe master #32

Are you sure you want to change the base?

Fork updates from ycm-core/YouCompleteMe master #32

Commits on Aug 19, 2022

Commits on Aug 20, 2022

Commits on Aug 21, 2022

Commits on Aug 24, 2022

Commits on Aug 27, 2022

Commits on Aug 28, 2022

Commits on Aug 29, 2022

Commits on Sep 22, 2022

Commits on Sep 27, 2022

Commits on Oct 6, 2022

Commits on Nov 1, 2022

Commits on Nov 12, 2022

Commits on Nov 18, 2022

Commits on Nov 19, 2022

Commits on Dec 10, 2022

Commits on Dec 14, 2022

Commits on Jan 3, 2023

Commits on Jan 9, 2023

Commits on Jan 16, 2023

Commits on Jan 17, 2023

Commits on Feb 7, 2023

Commits on Feb 21, 2023

Commits on Feb 27, 2023

Commits on Mar 9, 2023

Commits on Mar 17, 2023

Commits on Mar 18, 2023

Commits on Mar 20, 2023

Commits on Apr 6, 2023

Commits on Apr 17, 2023

Commits on Apr 19, 2023

Commits on Jun 10, 2023

Commits on Jun 11, 2023

Commits on Jun 12, 2023

Commits on Jun 27, 2023

Commits on Jul 5, 2023

Commits on Jul 6, 2023

Commits on Jul 19, 2023

Commits on Jul 25, 2023

Commits on Aug 18, 2023

Commits on Aug 19, 2023

Commits on Aug 28, 2023

Commits on Sep 10, 2023

Commits on Sep 12, 2023

Commits on Sep 13, 2023

Commits on Sep 14, 2023

Commits on Sep 27, 2023

Commits on Oct 3, 2023

Commits on Oct 4, 2023

Commits on Oct 6, 2023

Commits on Dec 21, 2023

Commits on Dec 23, 2023

Commits on Dec 28, 2023

Commits on Dec 29, 2023

Commits on Dec 30, 2023

Commits on Jan 4, 2024

Commits on Jan 5, 2024

Commits on Jan 9, 2024

Commits on Jan 14, 2024

Commits on Jan 31, 2024

Commits on Feb 1, 2024

Commits on Feb 3, 2024

Commits on Feb 4, 2024

Commits on Feb 5, 2024

Commits on Feb 14, 2024

Commits on Feb 18, 2024

Commits on Mar 4, 2024

Commits on Mar 20, 2024

Commits on May 11, 2024

Commits on May 13, 2024

Commits on May 14, 2024

Commits on May 17, 2024

Commits on Jun 9, 2024

Commits on Jun 10, 2024

Commits on Jun 11, 2024

Commits on Jun 12, 2024

Commits on Jun 18, 2024

Commits on Jun 19, 2024