Skip to content

1580 list extracts on schedule #1604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

casey-crawford-cfa
Copy link

No description provided.

Copy link

salesforce-cla bot commented May 8, 2025

Thanks for the contribution! Before we can merge this, we need @casey-crawford-cfa to sign the Salesforce Inc. Contributor License Agreement.

@casey-crawford-cfa
Copy link
Author

You already signed the CLA on 2025-05-08

I don't see the check getting updated though?

@bcantoni bcantoni closed this May 8, 2025
@bcantoni bcantoni reopened this May 8, 2025
@bcantoni
Copy link
Contributor

bcantoni commented May 8, 2025

I closed and reopened the PR the trigger the CLA bot and it seems happy now.

@bcantoni
Copy link
Contributor

@casey-crawford-cfa looks like you'll need one more pass with black formatting changes, then it should be green checks.

@jacalata could you please help with a code review here on this approach?

<extracts>
<extract id="task1"
priority="1"
type="incremental-or-full" >
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type doesn't matter here, but to make it useful for other tests could you put the value "IncrementalRefresh" instead of "incremental-or-full" here?

schedule_id = "c9cff7f9-309c-4361-99ff-d4ba8c9f5467"
# baseurl = f"{self.baseurl}/schedules/{schedule_id}/extracts"
baseurl = f"{self.server.baseurl}/sites/{self.server.site_id}/schedules/{schedule_id}/extracts"
# Fix the URL construction to match the endpoint pattern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover comments to be deleted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants