You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I came across SinglePaged today after struggling for a while on how to get my updated resume online. I'm very particular and I was about 30 minutes from breaking down and writing my own mini-CMS to handle it. Before I get into the bug report I just wanted to tell you that this is really fantastic and is almost exactly what I was looking for!
In any case, now that I have the rough skeleton of my site online I noticed there's a validation error in the the HTML on the page when the Google API key is included. The JS at the bottom of the page gets loaded outside the body tag and therefore is invalid. The fix is trivial and I made it already on my copy but I wanted to let you know upstream since it was the only issue I came across.
The last 4 lines of index.html should read:
{% include analytics.html %}
<script src="//ajax.googleapis.com/ajax/libs/jquery/2.1.1/jquery.min.js"></script>
<script src="site.js"></script>
</body>
</html>
I'd have created a patch but I figured it was would be more effort for you!
cheers,
Gabriel
The text was updated successfully, but these errors were encountered:
Hi there,
I came across SinglePaged today after struggling for a while on how to get my updated resume online. I'm very particular and I was about 30 minutes from breaking down and writing my own mini-CMS to handle it. Before I get into the bug report I just wanted to tell you that this is really fantastic and is almost exactly what I was looking for!
In any case, now that I have the rough skeleton of my site online I noticed there's a validation error in the the HTML on the page when the Google API key is included. The JS at the bottom of the page gets loaded outside the body tag and therefore is invalid. The fix is trivial and I made it already on my copy but I wanted to let you know upstream since it was the only issue I came across.
The last 4 lines of index.html should read:
I'd have created a patch but I figured it was would be more effort for you!
cheers,
Gabriel
The text was updated successfully, but these errors were encountered: