You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When use got with dnsCache, once hostname resolved, then until ttl, no lookup event emitted on the socket, so lookup time should be 0.
But above the code 2, dns never be 0 but tcp(connection time) will be 0.
When Server got a lot of traffic and got's socket connection delayed, value of tcp will not increased ( this always be 0 ), but value of dns increased.
I think this is causing confusion and needs to be fixed
The text was updated successfully, but these errors were encountered:
Motiveko
changed the title
Sometimes timings.phases.dns is not looup duration
Sometimes timings.phases.dns is not lookup duration
Oct 23, 2023
I use got http client and I use option
{dnsCache: true}
.In http-timer packages, theres's two code to calculate dns duration.
on socket's
lookup event
listenerhttp-timer/source/index.ts
Lines 93 to 98 in 62f6b38
deferToConnect()
's connect callback functionhttp-timer/source/index.ts
Lines 102 to 110 in 62f6b38
When use got with dnsCache, once hostname resolved, then until ttl, no lookup event emitted on the socket, so lookup time should be 0.
But above the code 2, dns never be 0 but tcp(connection time) will be 0.
When Server got a lot of traffic and got's socket connection delayed, value of tcp will not increased ( this always be 0 ), but value of dns increased.
I think this is causing confusion and needs to be fixed
The text was updated successfully, but these errors were encountered: