Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of pre-commits #124

Open
Danguilhen opened this issue May 19, 2023 · 1 comment
Open

Addition of pre-commits #124

Danguilhen opened this issue May 19, 2023 · 1 comment

Comments

@Danguilhen
Copy link

Hello,

I see you are not using pre-commits.
Pre-commits enable the code to have a better quality and the maintainability is much easier especially when multiple people are involved.

I suggest to duplicate my example from the package ipoly:
https://github.com/Danguilhen/ipoly/blob/0.1.6/.pre-commit-config.yaml

I can do the adjustments on a future PR if you agree on the idea !?

@szabgab
Copy link
Owner

szabgab commented May 19, 2023

I am personally not a fan of pre-commit hooks, I usually prefer to add such checks to the CI system.
However, recently I started to play with it. I'll take a look at it so I better understand it before we add it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants