Skip to content

Commit f27f809

Browse files
committed
ci: fail on high/critical vulnerabilities
Backstage pulls js-cookie 2.x (via react-use) and adm-zip 0.6.0 (via module-federation), and their ranges keep yarn from reaching the patched versions. Resolutions force them so the audit gate starts green.
1 parent d374ec7 commit f27f809

4 files changed

Lines changed: 15 additions & 10 deletions

File tree

‎.github/workflows/ci.yaml‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ jobs:
2020
- name: Install dependencies
2121
run: yarn install --immutable
2222

23+
- name: Audit
24+
run: just audit
25+
2326
- name: Lint
2427
run: just lint
2528

‎justfile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,4 +42,4 @@ check-unused:
4242

4343
# Checks for vulnerabilities
4444
audit: install
45-
yarn npm audit
45+
yarn npm audit --all --recursive --severity high

‎package.json‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,9 @@
2929
"resolutions": {
3030
"@types/react": "^18.0.0",
3131
"@types/react-dom": "^18.0.0",
32-
"@testing-library/react": "^16.0.0"
32+
"@testing-library/react": "^16.0.0",
33+
"adm-zip": "^0.6.1",
34+
"js-cookie": "^3.0.6"
3335
},
3436
"dependencies": {
3537
"@backstage/core-components": "^0.18.14",

‎yarn.lock‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7448,10 +7448,10 @@ __metadata:
74487448
languageName: node
74497449
linkType: hard
74507450

7451-
"adm-zip@npm:0.6.0":
7452-
version: 0.6.0
7453-
resolution: "adm-zip@npm:0.6.0"
7454-
checksum: 10c0/440f37590c62255226f1db4cb1a5a618879347f5106ad5b9a24c67c20f9a54bd5b4efcd2b35af858e39c7885d05f4bd35f4c2f42378c98d13f779be380bc9ae4
7451+
"adm-zip@npm:^0.6.1":
7452+
version: 0.6.1
7453+
resolution: "adm-zip@npm:0.6.1"
7454+
checksum: 10c0/78233c6fbfd418dd605ef3c4c6a656406a49f81f716f2850d565f5e55915f18b99f4fdaf15436d77c73536da0915eeca33adab8055872a983b0ac7d07664cd25
74557455
languageName: node
74567456
linkType: hard
74577457

@@ -14170,10 +14170,10 @@ __metadata:
1417014170
languageName: node
1417114171
linkType: hard
1417214172

14173-
"js-cookie@npm:^2.2.1":
14174-
version: 2.2.1
14175-
resolution: "js-cookie@npm:2.2.1"
14176-
checksum: 10c0/ee67fc0f8495d0800b851910b5eb5bf49d3033adff6493d55b5c097ca6da46f7fe666b10e2ecb13cfcaf5b88d71c205ce00a7e646de791689bfd053bbb36a376
14173+
"js-cookie@npm:^3.0.6":
14174+
version: 3.0.8
14175+
resolution: "js-cookie@npm:3.0.8"
14176+
checksum: 10c0/421912a4a55535bda32b3059835864e1182c3af5b4516df00a060edc1fa5a53d38bb8d5a91d5d305e396206f4fd11e829f17850aa5aa8164118c04d8ebf1ff5d
1417714177
languageName: node
1417814178
linkType: hard
1417914179

0 commit comments

Comments
 (0)