Re-enable 'load valid file' test. #1255
Merged
+330
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to get new save state files every time we update the minor version number of roadrunner. This (hopefully) puts in a linux version, meaning that only the macs will fail.
|
@adelhpour : can you please pull and build the latest 2.8.0, then run the test_state_saving test, then copy [build_dir]/test/stabilization/savedState.rr to [roadrunner]/test/models/StateSavingTests/savedState_mac.rr , then check that in to this branch, and see if we then pass? |
…Tests' directory per @luciansmith request in PR #1255
Also allow for two different macos versions.
… into load-valid-file
Not sure why the systems were separated?
This way, the action can be run only when we need it.
Should remove 4.3 bajillion warnings.
Warnings indicated we needed 13 more bytes of space to write potentially very large ints. Also, include more .h files in official list of headers.
The tests assume a certain number of spaces, so just keep that. We fix the warnings in case there are a ridiculous number, but this is unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to get new save state files every time we update the minor version number of roadrunner. This (hopefully) puts in a linux version, meaning that only the macs will fail so far. Once we get the fixed version of that, we can re-merge.