Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdata sections droped #34

Open
kmeinke opened this issue Oct 27, 2016 · 5 comments
Open

cdata sections droped #34

kmeinke opened this issue Oct 27, 2016 · 5 comments
Assignees

Comments

@kmeinke
Copy link

kmeinke commented Oct 27, 2016

cdata sections of xml datasources are not copied into the symphony page data xml. resulting in errors if cdata contains reserved xml character sequences. common use case for cdata are html fragments from WYSIWYG editors.

one solution may be the option to configure elements containing cdata and use this list in the
cdata-section-elements attribute of xsl:output.

a more radical solution could be to think if the extra xsl transformation of the datasoruce is realy nessesary. as far as i see it is only used to apply the xpath configured?

@nitriques
Copy link
Member

Hum I wonder why this happens.... Can you share the url of the remote DS for testing purpose ?

@nitriques
Copy link
Member

nitriques commented Nov 2, 2016

Does it works if you remove this line ?

@kmeinke
Copy link
Author

kmeinke commented Nov 3, 2016

can't share the dynamic datasource url. made you a static snapshot:

datasource: http://www.kontrast-consulting.de/test/source.xml
symphony page XML http://www.kontrast-consulting.de/test/result.xml

removal of that line hat no effect

@kmeinke
Copy link
Author

kmeinke commented Nov 3, 2016

as far as i understand the code, cdata sections are droped in this transformation because the $xsl has no cdata handling at all:

https://github.com/symphonycms/remote_datasource/blob/master/data-sources/datasource.remote.php#L943

@nitriques
Copy link
Member

We might giving a try to process it with the ninja technique... with cdata-section-elements ... mmm... Will try to test it. In the mean time, I would try to inject the cdata-section-elements manually.

@nitriques nitriques self-assigned this Nov 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants