-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Console] Document invokable command #20932
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 7.3
Are you sure you want to change the base?
Conversation
3d9b930
to
a59a80c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the harmonization of some command names 👍
#[AsCommand(name: 'app:create-user')] | ||
class CreateUserCommand |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe we should make all these changes with the #AsCommand attribute in a separate PR to avoid growing this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’d actually prefer to keep all these related changes in a single PR, since they’re closely tied together. It helps keep the context in one place and makes it easier to review everything as a whole.
In any case, we can go ahead and merge this one, then open a new PR for the remaining updates.
Thanks @alamirault and @OskarStark for your review 🙏 I’m actively looking for someone to help me refactor |
I would also add https://symfony.com/doc/current/console/input.html, wdyt @yceruto ? |
Thanks, Antoine! Sure, go for it. Here we're discussing input related topics symfony/symfony#59602 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yonel, thanks a lot for this massive contribution 🙇
I agree with what you said here:
we can go ahead and merge this one, then open a new PR for the remaining updates
I'll wait a bit to read more opinions, but that's the plan I'd like to follow. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with doing the work in steps, but I think the order should be swapped around.
We can't update all examples across the documentation to use features that we didn't document properly in my opinion. This applies in particular to console/input.rst
, which has to be updated before we can start using #[Option]
/#[Argument]
in the documentation.
But it would be perfectly fine if all articles in the docs still have outdated (too complex) examples, but the main guides are updated to document both the simple + advanced way.
We must also be careful about updating an example without updating the context it is placed in (I tried to comment on those cases whenever I saw this).
Thanks @wouterj, @94noni, and @javiereguiluz for your feedback! I will try to address it ASAP |
d05dc2a
to
3986174
Compare
3986174
to
244cf19
Compare
8b39fe4
to
f638390
Compare
2248692
to
fd23b35
Compare
fd23b35
to
585684e
Compare
FYI, Working on |
@@ -472,7 +412,7 @@ command: | |||
Note that it will not be called when the command is run without interaction | |||
(e.g. when passing the ``--no-interaction`` global option flag). | |||
|
|||
:method:`Symfony\\Component\\Console\\Command\\Command::execute` *(required)* | |||
``__invoke()`` *(required)* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
execute
is still in Lifecycle I think
``__invoke()`` *(required)* | |
``__invoke()`` and :method:`Symfony\\Component\\Console\\Command\\Command::execute` *(required)* |
What do you think ?
Closes #20553
Pending docs to be updated: