[Messenger] Document stamps in HandleTrait::handle #20851
Conversation
|
Hi @Fan2Shrek, This looks good to me. |
messenger.rst
Outdated
| @@ -2512,6 +2512,15 @@ wherever you need a query bus behavior instead of the ``MessageBusInterface``:: | |||
| } | |||
| } | |||
|
|
|||
| You also can also specify stamps when handling a message. For example, you can | |||
There was a problem hiding this comment.
What does specify mean here? Is it about adding new stamps to the message? What if you add a stamp of the same type that some existing stamp: is it appended or overwritten? Thanks!
There was a problem hiding this comment.
Good points! I committed some refinements. Does it look good to you?
carsonbot
changed the title
|
Merged! Thanks Pierre. |
| @@ -2512,6 +2512,20 @@ wherever you need a query bus behavior instead of the ``MessageBusInterface``:: | |||
| } | |||
| } | |||
|
|
|||
| You also can also add stamps when handling a message. For example, you can | |||
| add an ``DoctrineFlushStamp`` to flush the entity manager after handling the message:: | |||
There was a problem hiding this comment.
This stamp doss not exists in the symfony core maybe we should alternative or describe it as MyCustomStamp.
There was a problem hiding this comment.
Oops, I'll take a look at it later today 😅
There was a problem hiding this comment.
Thanks Alexander! I wasn't aware of this.
We updated the example directly in 7f9f20f but if you think this needs further changes, please create a Pull Request. Thanks!
There was a problem hiding this comment.
Looks good @javiereguiluz 👍
Fix #20842