Skip to content

Commit c977301

Browse files
Merge branch '5.0' into 5.1
* 5.0: fix merge Require PHPUnit 9.3 on PHP 8 [Cache] fix catching auth errors Fix CS [FrameworkBundle] set default session.handler alias if handler_id is not provided Fix CS Readability update Fix checks for phpunit releases on Composer 2 (resolves #37601) [Serializer] Support multiple levels of discriminator mapping Use hexadecimal numerals instead of hexadecimals in strings to represent error codes. [SCA] Minor fixes on tests [WebProfilerBundle] modified url generation to use absolute urls [Mailer] Fix reply-to functionality in the SendgridApiTransport [Mime] Fix compat with HTTP requests ticket_36879 - Fix mandrill raw http request setting from email/name
2 parents f9e052b + 825b66f commit c977301

File tree

2 files changed

+41
-2
lines changed

2 files changed

+41
-2
lines changed

Normalizer/AbstractObjectNormalizer.php

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -223,8 +223,9 @@ protected function instantiateObject(array &$data, string $class, array &$contex
223223
throw new RuntimeException(sprintf('The type "%s" has no mapped class for the abstract object "%s".', $type, $class));
224224
}
225225

226-
$class = $mappedClass;
227-
$reflectionClass = new \ReflectionClass($class);
226+
if ($mappedClass !== $class) {
227+
return $this->instantiateObject($data, $mappedClass, $context, new \ReflectionClass($mappedClass), $allowedAttributes, $format);
228+
}
228229
}
229230

230231
return parent::instantiateObject($data, $class, $context, $reflectionClass, $allowedAttributes, $format);

Tests/Normalizer/AbstractObjectNormalizerTest.php

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
use Symfony\Component\Serializer\Exception\NotNormalizableValueException;
2020
use Symfony\Component\Serializer\Mapping\ClassDiscriminatorFromClassMetadata;
2121
use Symfony\Component\Serializer\Mapping\ClassDiscriminatorMapping;
22+
use Symfony\Component\Serializer\Mapping\ClassDiscriminatorResolverInterface;
2223
use Symfony\Component\Serializer\Mapping\ClassMetadata;
2324
use Symfony\Component\Serializer\Mapping\ClassMetadataInterface;
2425
use Symfony\Component\Serializer\Mapping\Factory\ClassMetadataFactory;
@@ -235,6 +236,43 @@ public function hasMetadataFor($value): bool
235236
$this->assertInstanceOf(DummySecondChildQuux::class, $normalizedData->quux);
236237
}
237238

239+
public function testDenormalizeWithNestedDiscriminatorMap()
240+
{
241+
$classDiscriminatorResolver = new class() implements ClassDiscriminatorResolverInterface {
242+
public function getMappingForClass(string $class): ?ClassDiscriminatorMapping
243+
{
244+
switch ($class) {
245+
case AbstractDummy::class:
246+
return new ClassDiscriminatorMapping('type', [
247+
'foo' => AbstractDummyFirstChild::class,
248+
]);
249+
case AbstractDummyFirstChild::class:
250+
return new ClassDiscriminatorMapping('nested_type', [
251+
'bar' => AbstractDummySecondChild::class,
252+
]);
253+
default:
254+
return null;
255+
}
256+
}
257+
258+
public function getMappingForMappedObject($object): ?ClassDiscriminatorMapping
259+
{
260+
return null;
261+
}
262+
263+
public function getTypeForMappedObject($object): ?string
264+
{
265+
return null;
266+
}
267+
};
268+
269+
$normalizer = new AbstractObjectNormalizerDummy(null, null, null, $classDiscriminatorResolver);
270+
271+
$denormalizedData = $normalizer->denormalize(['type' => 'foo', 'nested_type' => 'bar'], AbstractDummy::class);
272+
273+
$this->assertInstanceOf(AbstractDummySecondChild::class, $denormalizedData);
274+
}
275+
238276
/**
239277
* Test that additional attributes throw an exception if no metadata factory is specified.
240278
*/

0 commit comments

Comments
 (0)