[HttpClient] Curl http client has to reinit curl multi handle on reset

Author: Rokas Mikalkėnas

CurlHttpClient.php

@@ -360,6 +360,9 @@ public function reset()
                 curl_setopt($ch, \CURLOPT_VERBOSE, false);
             }
         }
+
+        curl_multi_close($this->multi->handle);
+        $this->multi->handle = curl_multi_init();
     }
 
     /**

Tests/CurlHttpClientTest.php

@@ -136,6 +136,18 @@ public function testTimeoutIsNotAFatalError()
         parent::testTimeoutIsNotAFatalError();
     }
 
+    public function testHandleIsReinitOnReset()
+    {
+        $httpClient = $this->getHttpClient(__FUNCTION__);
+
+        $r = new \ReflectionProperty($httpClient, 'multi');
+        $r->setAccessible(true);
+        $clientState = $r->getValue($httpClient);
+        $initialHandleId = (int) $clientState->handle;
+        $httpClient->reset();
+        self::assertNotSame($initialHandleId, (int) $clientState->handle);
+    }
+
     private function getVulcainClient(): CurlHttpClient
     {
         if (\PHP_VERSION_ID >= 70300 && \PHP_VERSION_ID < 70304) {