bug #50256 [HttpClient] Fix setting duplicate-name headers when redirecting with AmpHttpClient (nicolas-grekas)

fabpot · fabpot · commit 9e89ac4c9dfe · 2023-05-07T15:11:28.000+02:00
This PR was merged into the 5.4 branch.

Discussion
----------

[HttpClient] Fix setting duplicate-name headers when redirecting with AmpHttpClient

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Spotted by `@kelunik` 🙏

Commits
-------

5ff1db081f [HttpClient] Fix setting duplicate-name headers when redirecting with AmpHttpClient
diff --git a/Response/AmpResponse.php b/Response/AmpResponse.php
@@ -357,7 +357,7 @@ private static function followRedirects(Request $originRequest, AmpClientState $
             }
 
             foreach ($originRequest->getRawHeaders() as [$name, $value]) {
-                $request->setHeader($name, $value);
+                $request->addHeader($name, $value);
             }
 
             if ($request->getUri()->getAuthority() !== $originRequest->getUri()->getAuthority()) {

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,7 @@ private static function followRedirects(Request $originRequest, AmpClientState $`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`foreach ($originRequest->getRawHeaders() as [$name, $value]) {`
`360`		`- $request->setHeader($name, $value);`
	`360`	`+ $request->addHeader($name, $value);`
`361`	`361`	`}`
`362`	`362`
`363`	`363`	`if ($request->getUri()->getAuthority() !== $originRequest->getUri()->getAuthority()) {`