[HttpClient] always send Content-Length when a body is passed

nicolas-grekas · nicolas-grekas · commit 6e4b3e0e57fa · 2022-03-25T15:52:11.000+01:00
diff --git a/NativeHttpClient.php b/NativeHttpClient.php
@@ -80,9 +80,11 @@ public function request(string $method, string $url, array $options = []): Respo
             }
         }
 
+        $sendContentLength = !\is_string($options['body']) || 'POST' === $method;
+
         $options['body'] = self::getBodyAsString($options['body']);
 
-        if ('' === $options['body'] && 'POST' === $method && !isset($options['normalized_headers']['content-length'])) {
+        if ('' === $options['body'] && $sendContentLength && !isset($options['normalized_headers']['content-length'])) {
             $options['headers'][] = 'Content-Length: 0';
         }
         if (('' !== $options['body'] || 'POST' === $method) && !isset($options['normalized_headers']['content-type'])) {

Original file line number	Diff line number	Diff line change
`@@ -80,9 +80,11 @@ public function request(string $method, string $url, array $options = []): Respo`
`80`	`80`	`}`
`81`	`81`	`}`
`82`	`82`
	`83`	`+ $sendContentLength = !\is_string($options['body']) \|\| 'POST' === $method;`
	`84`	`+`
`83`	`85`	`$options['body'] = self::getBodyAsString($options['body']);`
`84`	`86`
`85`		`- if ('' === $options['body'] && 'POST' === $method && !isset($options['normalized_headers']['content-length'])) {`
	`87`	`+ if ('' === $options['body'] && $sendContentLength && !isset($options['normalized_headers']['content-length'])) {`
`86`	`88`	`$options['headers'][] = 'Content-Length: 0';`
`87`	`89`	`}`
`88`	`90`	`if (('' !== $options['body'] \|\| 'POST' === $method) && !isset($options['normalized_headers']['content-type'])) {`