Ensure all properties have a type

Author: nicolas-grekas

Internal/AmpClientState.php

@@ -145,15 +145,16 @@ private function getClient(array $options): array
         $options['crypto_method'] && $context = $context->withMinimumVersion($options['crypto_method']);
 
         $connector = $handleConnector = new class() implements Connector {
-            public $connector;
-            public $uri;
+            public DnsConnector $connector;
+            public string $uri;
+            /** @var resource|null */
             public $handle;
 
             public function connect(string $uri, ConnectContext $context = null, CancellationToken $token = null): Promise
             {
                 $result = $this->connector->connect($this->uri ?? $uri, $context, $token);
                 $result->onResolve(function ($e, $socket) {
-                    $this->handle = null !== $socket ? $socket->getResource() : false;
+                    $this->handle = $socket?->getResource();
                 });
 
                 return $result;

Internal/AmpListener.php

@@ -28,6 +28,7 @@ class AmpListener implements EventListener
     private array $info;
     private array $pinSha256;
     private \Closure $onProgress;
+    /** @var resource|null */
     private $handle;
 
     public function __construct(array &$info, array $pinSha256, \Closure $onProgress, &$handle)

Response/AsyncContext.php

@@ -25,10 +25,12 @@
  */
 final class AsyncContext
 {
+    /** @var callable|null */
     private $passthru;
     private HttpClientInterface $client;
     private ResponseInterface $response;
     private array $info = [];
+    /** @var resource|null */
     private $content;
     private int $offset;
 

Response/AsyncResponse.php

@@ -37,6 +37,7 @@ class AsyncResponse implements ResponseInterface, StreamableInterface
     private ?HttpClientInterface $client;
     private ResponseInterface $response;
     private array $info = ['canceled' => false];
+    /** @var callable|null */
     private $passthru;
     private ?\Iterator $stream = null;
     private ?int $yieldedState = null;

Response/CommonResponseTrait.php

@@ -30,7 +30,9 @@ trait CommonResponseTrait
      * @var callable|null A callback that tells whether we're waiting for response headers
      */
     private $initializer;
+    /** @var bool|\Closure|resource|null */
     private $shouldBuffer;
+    /** @var resource|null */
     private $content;
     private int $offset = 0;
     private ?array $jsonData = null;

Response/NativeResponse.php

@@ -34,8 +34,8 @@ final class NativeResponse implements ResponseInterface, StreamableInterface
      */
     private $context;
     private string $url;
-    private $resolver;
-    private $onProgress;
+    private \Closure $resolver;
+    private ?\Closure $onProgress;
     private ?int $remaining = null;
 
     /**
@@ -58,8 +58,8 @@ public function __construct(NativeClientState $multi, $context, string $url, arr
         $this->logger = $logger;
         $this->timeout = $options['timeout'];
         $this->info = &$info;
-        $this->resolver = $resolver;
-        $this->onProgress = $onProgress;
+        $this->resolver = $resolver(...);
+        $this->onProgress = $onProgress ? $onProgress(...) : null;
         $this->inflate = !isset($options['normalized_headers']['accept-encoding']);
         $this->shouldBuffer = $options['buffer'] ?? true;
 
@@ -177,7 +177,7 @@ private function open(): void
         }
 
         stream_set_blocking($h, false);
-        $this->context = $this->resolver = null;
+        unset($this->context, $this->resolver);
 
         // Create dechunk buffers
         if (isset($this->headers['content-length'])) {

Response/TransportResponseTrait.php

@@ -38,7 +38,7 @@ trait TransportResponseTrait
         'canceled' => false,
     ];
 
-    /** @var object|resource */
+    /** @var object|resource|null */
     private $handle;
     private int|string $id;
     private ?float $timeout = 0;