Merge branch '6.1' into 6.2

* 6.1:
  [Messenger] cs fix
  [Messenger] Fix time-limit check exception
  [Console] Fix console `ProgressBar::override()` after manual `ProgressBar::cleanup()`
  [FrameworkBundle] typo default_lifetime example
  [HttpClient] Handle Amp HTTP client v5 incompatibility gracefully
  [HttpKernel] Don’t try to wire Response argument with controller.service_arguments
  [PhpUnitBridge] Fix language deprecations incorrectly marked as direct
  [FrameworkBundle] Removed unused $willBeAvailable params on Configuration
  [Cache] Remove extra type condition in MemcachedAdapter::createConnection()
  Tell about messenger:consume invalid limit options
  [Messenger] Do not throw 'no handlers' exception when skipping due to duplicate handling

Author: nicolas-grekas

AmpHttpClient.php

@@ -17,6 +17,7 @@
 use Amp\Http\Client\PooledHttpClient;
 use Amp\Http\Client\Request;
 use Amp\Http\Tunnel\Http1TunnelConnector;
+use Amp\Promise;
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 use Symfony\Component\HttpClient\Exception\TransportException;
@@ -29,7 +30,11 @@
 use Symfony\Contracts\Service\ResetInterface;
 
 if (!interface_exists(DelegateHttpClient::class)) {
-    throw new \LogicException('You cannot use "Symfony\Component\HttpClient\AmpHttpClient" as the "amphp/http-client" package is not installed. Try running "composer require amphp/http-client".');
+    throw new \LogicException('You cannot use "Symfony\Component\HttpClient\AmpHttpClient" as the "amphp/http-client" package is not installed. Try running "composer require amphp/http-client:^4.2.1".');
+}
+
+if (!interface_exists(Promise::class)) {
+    throw new \LogicException('You cannot use "Symfony\Component\HttpClient\AmpHttpClient" as the installed "amphp/http-client" is not compatible with this version of "symfony/http-client". Try downgrading "amphp/http-client" to "^4.2.1".');
 }
 
 /**

HttpClient.php

@@ -12,6 +12,7 @@
 namespace Symfony\Component\HttpClient;
 
 use Amp\Http\Client\Connection\ConnectionLimitingPool;
+use Amp\Promise;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 
 /**
@@ -30,7 +31,7 @@ final class HttpClient
      */
     public static function create(array $defaultOptions = [], int $maxHostConnections = 6, int $maxPendingPushes = 50): HttpClientInterface
     {
-        if ($amp = class_exists(ConnectionLimitingPool::class)) {
+        if ($amp = class_exists(ConnectionLimitingPool::class) && interface_exists(Promise::class)) {
             if (!\extension_loaded('curl')) {
                 return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);
             }
@@ -61,7 +62,7 @@ public static function create(array $defaultOptions = [], int $maxHostConnection
             return new AmpHttpClient($defaultOptions, null, $maxHostConnections, $maxPendingPushes);
         }
 
-        @trigger_error((\extension_loaded('curl') ? 'Upgrade' : 'Install').' the curl extension or run "composer require amphp/http-client" to perform async HTTP operations, including full HTTP/2 support', \E_USER_NOTICE);
+        @trigger_error((\extension_loaded('curl') ? 'Upgrade' : 'Install').' the curl extension or run "composer require amphp/http-client:^4.2.1" to perform async HTTP operations, including full HTTP/2 support', \E_USER_NOTICE);
 
         return new NativeHttpClient($defaultOptions, $maxHostConnections);
     }