Narrow existing return types on private/internal/final/test methods

Author: nicolas-grekas

GatewayApiTransportFactory.php

@@ -14,17 +14,13 @@
 use Symfony\Component\Notifier\Exception\UnsupportedSchemeException;
 use Symfony\Component\Notifier\Transport\AbstractTransportFactory;
 use Symfony\Component\Notifier\Transport\Dsn;
-use Symfony\Component\Notifier\Transport\TransportInterface;
 
 /**
  * @author Piergiuseppe Longo <[email protected]>
  */
 final class GatewayApiTransportFactory extends AbstractTransportFactory
 {
-    /**
-     * @return GatewayApiTransport
-     */
-    public function create(Dsn $dsn): TransportInterface
+    public function create(Dsn $dsn): GatewayApiTransport
     {
         $scheme = $dsn->getScheme();
 

Tests/GatewayApiTransportFactoryTest.php

@@ -4,18 +4,14 @@
 
 use Symfony\Component\Notifier\Bridge\GatewayApi\GatewayApiTransportFactory;
 use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
-use Symfony\Component\Notifier\Transport\TransportFactoryInterface;
 
 /**
  * @author Piergiuseppe Longo <[email protected]>
  * @author Oskar Stark <[email protected]>
  */
 final class GatewayApiTransportFactoryTest extends TransportFactoryTestCase
 {
-    /**
-     * @return GatewayApiTransportFactory
-     */
-    public function createFactory(): TransportFactoryInterface
+    public function createFactory(): GatewayApiTransportFactory
     {
         return new GatewayApiTransportFactory();
     }

Tests/GatewayApiTransportTest.php

@@ -9,7 +9,6 @@
 use Symfony\Component\Notifier\Message\SentMessage;
 use Symfony\Component\Notifier\Message\SmsMessage;
 use Symfony\Component\Notifier\Test\TransportTestCase;
-use Symfony\Component\Notifier\Transport\TransportInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use Symfony\Contracts\HttpClient\ResponseInterface;
 
@@ -19,10 +18,7 @@
  */
 final class GatewayApiTransportTest extends TransportTestCase
 {
-    /**
-     * @return GatewayApiTransport
-     */
-    public function createTransport(HttpClientInterface $client = null): TransportInterface
+    public function createTransport(HttpClientInterface $client = null): GatewayApiTransport
     {
         return new GatewayApiTransport('authtoken', 'Symfony', $client ?? $this->createMock(HttpClientInterface::class));
     }