Skip to content

Commit 461bbc7

Browse files
committed
feature #58335 [Notifier] deprecate the TransportFactoryTestCase (xabbuh)
This PR was merged into the 7.2 branch. Discussion ---------- [Notifier] deprecate the TransportFactoryTestCase | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | yes | Issues | Fix #54100 | License | MIT Commits ------- c8b0fcc77b deprecate the TransportFactoryTestCase
2 parents 103a191 + cd71427 commit 461bbc7

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

Tests/GatewayApiTransportFactoryTest.php

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,19 @@
1212
namespace Symfony\Component\Notifier\Bridge\GatewayApi\Tests;
1313

1414
use Symfony\Component\Notifier\Bridge\GatewayApi\GatewayApiTransportFactory;
15-
use Symfony\Component\Notifier\Test\TransportFactoryTestCase;
15+
use Symfony\Component\Notifier\Test\AbstractTransportFactoryTestCase;
16+
use Symfony\Component\Notifier\Test\IncompleteDsnTestTrait;
17+
use Symfony\Component\Notifier\Test\MissingRequiredOptionTestTrait;
1618

1719
/**
1820
* @author Piergiuseppe Longo <[email protected]>
1921
* @author Oskar Stark <[email protected]>
2022
*/
21-
final class GatewayApiTransportFactoryTest extends TransportFactoryTestCase
23+
final class GatewayApiTransportFactoryTest extends AbstractTransportFactoryTestCase
2224
{
25+
use IncompleteDsnTestTrait;
26+
use MissingRequiredOptionTestTrait;
27+
2328
public function createFactory(): GatewayApiTransportFactory
2429
{
2530
return new GatewayApiTransportFactory();
@@ -48,4 +53,9 @@ public static function missingRequiredOptionProvider(): iterable
4853
{
4954
yield 'missing option: from' => ['gatewayapi://[email protected]'];
5055
}
56+
57+
public static function unsupportedSchemeProvider(): iterable
58+
{
59+
yield ['somethingElse://login:apiKey@default'];
60+
}
5161
}

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"require": {
2323
"php": ">=8.2",
2424
"symfony/http-client": "^6.4|^7.0",
25-
"symfony/notifier": "^6.4|^7.0"
25+
"symfony/notifier": "^7.2"
2626
},
2727
"autoload": {
2828
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\GatewayApi\\": "" },

0 commit comments

Comments
 (0)