Skip to content

Commit 3b40c3c

Browse files
[Notifier] Make TransportTestCase data providers static
1 parent 42b4e3c commit 3b40c3c

File tree

2 files changed

+11
-10
lines changed

2 files changed

+11
-10
lines changed

Tests/GatewayApiTransportTest.php

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,11 @@
1414
use Symfony\Component\HttpClient\MockHttpClient;
1515
use Symfony\Component\Notifier\Bridge\GatewayApi\GatewayApiTransport;
1616
use Symfony\Component\Notifier\Message\ChatMessage;
17-
use Symfony\Component\Notifier\Message\MessageInterface;
1817
use Symfony\Component\Notifier\Message\SentMessage;
1918
use Symfony\Component\Notifier\Message\SmsMessage;
2019
use Symfony\Component\Notifier\Test\TransportTestCase;
20+
use Symfony\Component\Notifier\Tests\Fixtures\DummyHttpClient;
21+
use Symfony\Component\Notifier\Tests\Fixtures\DummyMessage;
2122
use Symfony\Component\Notifier\Transport\TransportInterface;
2223
use Symfony\Contracts\HttpClient\HttpClientInterface;
2324
use Symfony\Contracts\HttpClient\ResponseInterface;
@@ -31,25 +32,25 @@ final class GatewayApiTransportTest extends TransportTestCase
3132
/**
3233
* @return GatewayApiTransport
3334
*/
34-
public function createTransport(HttpClientInterface $client = null): TransportInterface
35+
public static function createTransport(HttpClientInterface $client = null): TransportInterface
3536
{
36-
return new GatewayApiTransport('authtoken', 'Symfony', $client ?? $this->createMock(HttpClientInterface::class));
37+
return new GatewayApiTransport('authtoken', 'Symfony', $client ?? new DummyHttpClient());
3738
}
3839

39-
public function toStringProvider(): iterable
40+
public static function toStringProvider(): iterable
4041
{
41-
yield ['gatewayapi://gatewayapi.com?from=Symfony', $this->createTransport()];
42+
yield ['gatewayapi://gatewayapi.com?from=Symfony', self::createTransport()];
4243
}
4344

44-
public function supportedMessagesProvider(): iterable
45+
public static function supportedMessagesProvider(): iterable
4546
{
4647
yield [new SmsMessage('0611223344', 'Hello!')];
4748
}
4849

49-
public function unsupportedMessagesProvider(): iterable
50+
public static function unsupportedMessagesProvider(): iterable
5051
{
5152
yield [new ChatMessage('Hello!')];
52-
yield [$this->createMock(MessageInterface::class)];
53+
yield [new DummyMessage()];
5354
}
5455

5556
public function testSend()
@@ -68,7 +69,7 @@ public function testSend()
6869

6970
$message = new SmsMessage('3333333333', 'Hello!');
7071

71-
$transport = $this->createTransport($client);
72+
$transport = self::createTransport($client);
7273
$sentMessage = $transport->send($message);
7374

7475
$this->assertInstanceOf(SentMessage::class, $sentMessage);

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"require": {
2323
"php": ">=7.2.5",
2424
"symfony/http-client": "^4.3|^5.0|^6.0",
25-
"symfony/notifier": "^5.3|^6.0"
25+
"symfony/notifier": "^5.4.21|^6.2.7"
2626
},
2727
"autoload": {
2828
"psr-4": { "Symfony\\Component\\Notifier\\Bridge\\GatewayApi\\": "" },

0 commit comments

Comments
 (0)