Skip to content

Commit f893877

Browse files
committed
minor #58374 Remove useless parent method calls in tests (alexandre-daubois)
This PR was merged into the 7.2 branch. Discussion ---------- Remove useless parent method calls in tests | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT The vast majority of tests don't call these parent methods, because they are no op. There are a few places where they are called, let's remove them? Commits ------- b54596f604 Remove useless parent method calls in tests
2 parents bdf4a90 + 9c44ae8 commit f893877

File tree

7 files changed

+0
-14
lines changed

7 files changed

+0
-14
lines changed

Tests/ChoiceList/AbstractChoiceListTestCase.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,6 @@ abstract class AbstractChoiceListTestCase extends TestCase
3939

4040
protected function setUp(): void
4141
{
42-
parent::setUp();
43-
4442
$this->list = $this->createChoiceList();
4543

4644
$choices = $this->getChoices();

Tests/Extension/Core/DataTransformer/DateTimeToLocalizedStringTransformerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ class DateTimeToLocalizedStringTransformerTest extends BaseDateTimeTransformerTe
3131

3232
protected function setUp(): void
3333
{
34-
parent::setUp();
35-
3634
// Normalize intl. configuration settings.
3735
if (\extension_loaded('intl')) {
3836
$this->initialTestCaseUseException = ini_set('intl.use_exceptions', 0);

Tests/Extension/Core/DataTransformer/DateTimeToRfc3339TransformerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,6 @@ class DateTimeToRfc3339TransformerTest extends BaseDateTimeTransformerTestCase
2525

2626
protected function setUp(): void
2727
{
28-
parent::setUp();
29-
3028
$this->dateTime = new \DateTime('2010-02-03 04:05:06 UTC');
3129
$this->dateTimeWithoutSeconds = new \DateTime('2010-02-03 04:05:00 UTC');
3230
}

Tests/Extension/Core/Type/MoneyTypeTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ protected function setUp(): void
3333

3434
protected function tearDown(): void
3535
{
36-
parent::tearDown();
37-
3836
\Locale::setDefault($this->defaultLocale);
3937
}
4038

Tests/Extension/Core/Type/NumberTypeTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ protected function setUp(): void
3535

3636
protected function tearDown(): void
3737
{
38-
parent::tearDown();
39-
4038
\Locale::setDefault($this->defaultLocale);
4139
}
4240

Tests/Extension/Core/Type/PercentTypeTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,6 @@ protected function setUp(): void
3434

3535
protected function tearDown(): void
3636
{
37-
parent::tearDown();
38-
3937
\Locale::setDefault($this->defaultLocale);
4038
}
4139

Tests/NativeRequestHandlerTest.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ protected function setUp(): void
4141

4242
protected function tearDown(): void
4343
{
44-
parent::tearDown();
45-
4644
$_GET = [];
4745
$_POST = [];
4846
$_FILES = [];

0 commit comments

Comments
 (0)