Skip to content

Commit 72f526d

Browse files
committed
feature #34363 [HttpFoundation] Add InputBag (azjezz)
This PR was merged into the 5.1-dev branch. Discussion ---------- [HttpFoundation] Add InputBag | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | Deprecations? | yes | License | MIT When ppl read a request attribute, they never check if an array is returned This means many apps just fail with a 500 when adding `[]` in the query string. This PR turns them to 400 basically (with a deprecation for now) Commits ------- 0a2ef70c04 [HttpFoundation] add InputBag
2 parents 91cab01 + 41f9af0 commit 72f526d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Extension/HttpFoundation/HttpFoundationRequestHandler.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function handleRequest(FormInterface $form, $request = null)
6363
return;
6464
}
6565

66-
$data = $request->query->get($name);
66+
$data = $request->query->all()[$name];
6767
}
6868
} else {
6969
// Mark the form with an error if the uploaded size was too large
@@ -87,7 +87,7 @@ public function handleRequest(FormInterface $form, $request = null)
8787
$files = $request->files->all();
8888
} elseif ($request->request->has($name) || $request->files->has($name)) {
8989
$default = $form->getConfig()->getCompound() ? [] : null;
90-
$params = $request->request->get($name, $default);
90+
$params = $request->request->all()[$name] ?? $default;
9191
$files = $request->files->get($name, $default);
9292
} else {
9393
// Don't submit the form if it is not present in the request

0 commit comments

Comments
 (0)