AutoRouteManager doesn't re-translate objects back to current translation

[jnssthl]

Hi,
The AutoRouteManager translates Documents onFlush to any available locale in order to generate their Uri:

Line 101: $this->adapter->translateObject($uriContextCollection->getSubjectObject(), $locale);

But does not translate them back to the translation they had right before they were persisted/flushed.
In my case this leads to that I need to translate my object back:

$document = $dm->findTranslation(null, '/cms/document', 'de');
// => available locales: en, de
$document->setTitle('New title');

$dm = $this->get('doctrine_phpcr.odm.document_manager');
$dm->persist($page);
$dm->flush();

// $document->getLocale() => 'en'

Is this intended, or am I missing something? ;-)

Cheers

[dantleech]

Hi, its certainly not "intended" behavior.. it makes sense that the document should be in the same locale after the flush.

I wonder what the best solution would be.. maybe reloading the documents to their original "current" locales after the flush has finished.. I guess that should not incur to much of a performance penalty.

@dbu @lsmith77 can you think of any other options?

[lsmith77]

with the latest version of the ODM I think its should be very cheap to switch back as we keep the data in memory.

[wouterj]

So, what has to be done here? Not knowing that much about the ODM, what "loading" are you talking about here? DocumentManager#find() ?

[dbu]

we talk about findTranslation. should be repeated with the orig locale after generating route. dm has a method to get current locale of doc if i am not mistaken

[wouterj]

Hmm, I see no method like that at the moment (only {bind|find|remove}Translation and getLocalesFor).

[dbu]

indeed. the method is on the unit of work. its called getCurrentLocale.

now we have a couple of new challenges:

• AdapterInterface::translateObject assumes that the object itself can
  be translated. imho this is not very flexible - some systems might need
  to return a different object that represents the other language.
• we could add something to the interface to make this work (like record
  translation and restore translation or something like that). what i
  would prefer is declaring translateObject to return something and make
  AutoRouteManager::getUriContextsForDocument use the return value. for
  phpcr-odm, we could then record the locale of the document with
  uow->getCurrentLocale, fetch the translation, clone the document and
  then re-fetch the original language to set it back, then return the
  clone. i see no simpler solution unfortunately - phpcr-odm currently has
  no method to get a detached translation directly. if the
  getCurrentLocale is the same as the requested, we can just return the
  document.

wdyt?

[wouterj]

@dbu I agree about the returning part, did that in symfony-cmf/routing-auto#53

I've fixed the locale bug in the listener instead: #159 I think this is a lot cleaner than cloning the document and such.

[dantleech]

I guess @wouterj has now addressed both issues raised by @dbu.