Merge pull request #205 from symfony-cmf/styleci

fix styleci configuration

Author: dbu

.styleci.yml

@@ -15,12 +15,10 @@
 
 
 preset: symfony
+risky: true
 
 enabled:
   - combine_consecutive_unsets
-  - short_array_syntax
-  - newline_after_open_tag
-  - no_php4_constructor
   - no_useless_else
   - ordered_use
   - strict

src/DependencyInjection/Compiler/TestContainerPass.php

@@ -34,7 +34,7 @@ public function __construct(array $services = [])
     public function process(ContainerBuilder $container)
     {
         foreach ($container->getDefinitions() as $id => $definition) {
-            if (in_array($id, $this->services, true)) {
+            if (\in_array($id, $this->services, true)) {
                 $definition->setPublic(true);
             }
         }

src/Functional/BaseTestCase.php

@@ -60,7 +60,7 @@ public function getFrameworkBundleClient()
     {
         if (null === $this->client) {
             // property does not exist in all symfony versions
-            if (\property_exists(self::class, 'booted') && self::$booted) {
+            if (property_exists(self::class, 'booted') && self::$booted) {
                 self::ensureKernelShutdown();
             }
             $this->client = self::createClient($this->getKernelConfiguration());

src/Functional/DbManager/ORM.php

@@ -47,8 +47,6 @@ class ORM
 
     /**
      * Constructor.
-     *
-     * @param ContainerInterface $container
      */
     public function __construct(ContainerInterface $container)
     {

src/HttpKernel/TestKernel.php

@@ -166,7 +166,7 @@ public function getProjectDir()
     {
         $refl = new \ReflectionClass($this);
         $fname = $refl->getFileName();
-        $kernelDir = dirname($fname);
+        $kernelDir = \dirname($fname);
 
         return $kernelDir;
     }
@@ -217,7 +217,7 @@ protected function registerConfiguredBundles()
     protected function build(ContainerBuilder $container)
     {
         parent::build($container);
-        if (in_array($this->getEnvironment(), ['test', 'phpcr']) && file_exists($this->getKernelDir().'/config/public_services.php')) {
+        if (\in_array($this->getEnvironment(), ['test', 'phpcr']) && file_exists($this->getKernelDir().'/config/public_services.php')) {
             $services = require $this->getKernelDir().'/config/public_services.php';
             $container->addCompilerPass(new TestContainerPass($services), PassConfig::TYPE_OPTIMIZE);
         }

src/Unit/Constraint/SchemaAcceptsXml.php

@@ -52,7 +52,7 @@ public function matches($schemaFile): bool
 
     public function count(): int
     {
-        return count($this->xml);
+        return \count($this->xml);
     }
 
     public function toString(): string

src/Unit/XmlSchemaTestCase.php

@@ -32,12 +32,12 @@ public static function assertSchemaRefusesXml($xmlDoms, $schemaPath, $message =
 
     private static function getSchemaAcceptsXmlConstraint($xmlDoms)
     {
-        if (!is_array($xmlDoms)) {
+        if (!\is_array($xmlDoms)) {
             $xmlDoms = [$xmlDoms];
         }
 
         $xmlDoms = array_map(function ($dom) {
-            if (is_string($dom)) {
+            if (\is_string($dom)) {
                 $xml = $dom;
                 $dom = new \DOMDocument();
                 $dom->load($xml);
@@ -46,7 +46,7 @@ private static function getSchemaAcceptsXmlConstraint($xmlDoms)
             }
 
             if (!$dom instanceof \DOMDocument) {
-                throw new \InvalidArgumentException(sprintf('The first argument of assertSchemaAcceptsXml should be instances of \DOMDocument, "%s" given', get_class($dom)));
+                throw new \InvalidArgumentException(sprintf('The first argument of assertSchemaAcceptsXml should be instances of \DOMDocument, "%s" given', \get_class($dom)));
             }
 
             return $dom;

tests/bootstrap.php

@@ -14,7 +14,7 @@
 if (!$loader = include $vendorDir.'/autoload.php') {
     $nl = PHP_SAPI === 'cli' ? PHP_EOL : '<br />';
     echo "$nl$nl";
-    die('You must set up the project dependencies.'.$nl.
+    exit('You must set up the project dependencies.'.$nl.
         'Run the following commands in '.dirname(__DIR__).':'.$nl.$nl.
         'curl -s http://getcomposer.org/installer | php'.$nl.
         'php composer.phar install'.$nl);