ocibundle: confusing Create / Prepare function naming #2303
Description
Type of issue
technical debt
Description of issue
In #2302 the tools.CreateOverlayTmpfs that creates a tmpfs, and overlay mounts it onto a rootfs, was refactored so that it calls a new tools.PrepareOverlayTmpfs which only creates the tmpfs.
The naming of these functions is confusing, but is limited by the fact that they are in the public API under pkg/
We could perhaps envisage a 3-way split of the functionality
tools.PrepareOverlayTmpfstools.MountOverlayTmpfstools.PrepareAndMountOverlayTmpfs
(or similar), where tools.CreateOverlayTmpfs can then be made a deprecated alias of tools.PrepareAndMountOverlayTmpfs.