-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ActiveSupport interface? #2
Comments
Have you taken a close look at the API |
What sized-based constraints? |
For example, the handling of a universal option such as |
So are you saying you're against the idea of a |
Not at all. I'm saying that some interesting choices have to be made with respect to how to satisfy the so-called "universal" requirements for all stores in a manner that doesn't throw away the performance benefits of fast_cache. I did not have a strong gut sense on this (or a need for it), which is the only reason why I did not create a separate project as you suggest. If you want to go ahead and do this, I'd be happy to do a code review. |
Nice work with this project. I came to it after looking into why something as ostensibly simple as
ActiveSupport::Cache::MemoryStore
is slower than I expected, and figuring someone had written something better (and you have!). So thanks for that.The
MemoryStore
is aActiveSupport::Cache::Store
, the primary benefit of which is a cache backend-agnostic interface. Would you be interested in makingfast_cache
inherit fromActiveSupport::Cache::Store
, so that it can seamlessly replaceMemoryStore
? I understand if you want to keep this implementationActiveSupport
-free, but maybe a new project such asfast_cache_store
?Would like to hear your thoughts.
The text was updated successfully, but these errors were encountered: