Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: Get rid of the window.location.href implementation in the post-linkarea component #4688

Closed
oliverschuerch opened this issue Feb 17, 2025 · 0 comments
Closed

[bug]: Get rid of the window.location.href implementation in the post-linkarea component #4688

oliverschuerch opened this issue Feb 17, 2025 · 0 comments
Assignees
@alizedebray
Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Milestone
PPNL Support

Comments

@oliverschuerch
Copy link
Contributor

The post-linkarea component is using window.location.href but is used as an SSR component in the PPNL Project.
Since we can't access the window object on the server, this is causing an error.
@oliverschuerch oliverschuerch added 🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package labels Feb 17, 2025
@oliverschuerch oliverschuerch added this to the PPNL Support milestone Feb 17, 2025
@oliverschuerch oliverschuerch moved this from 👀 Triage to 💻 Ready for development in Design System Production Board Feb 17, 2025
@alizedebray alizedebray linked a pull request Feb 17, 2025 that will close this issue
chore(component): stop using the window object in the post-linkarea #4691
Closed
@alizedebray alizedebray moved this from 💻 Ready for development to 🕹️ Coding in progress in Design System Production Board Feb 17, 2025
@alizedebray alizedebray moved this from 🕹️ Coding in progress to 🚀 Done in Design System Production Board Feb 19, 2025
@alizedebray alizedebray closed this as completed by moving to 🚀 Done in Design System Production Board Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
🐞 bug Something isn't working 📦 components Related to the @swisspost/design-system-components package
Projects
Design System Production Board
Status: 🚀 Done
Milestone
PPNL Support
Development

Successfully merging a pull request may close this issue.

chore(component): stop using the window object in the post-linkarea swisspost/design-system
2 participants
@oliverschuerch @alizedebray