Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swift-testing: If LSP is disabled, swift-testing tests do not work #892

Open
adam-fowler opened this issue Jun 13, 2024 · 1 comment
Open

Comments

@adam-fowler
Copy link
Contributor

It appears swift-testing tests are not flagged as swift-testing until they are found via the workspace/tests or textDocument/tests LSP requests. We need another way to catch this. While disabling SourceKit-LSP is a special situation, it could occur in situations where LSP is particularly slow in large projects.

@award999
Copy link
Contributor

Swift-testing is more complex than XCTests so Paul said he would be hesitant to parse this. Some ideas:

  1. Update setting description, warning if they disable sourcekit-lsp, they lose this functionality
  2. Update warning notification message that shows up to kill the LSP
  3. Provide warning in testing view (if we can still show XCTests at same time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants