Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning and error messages are truncated in Problems view #1074

Closed
HeMet opened this issue Sep 17, 2024 · 2 comments
Closed

Warning and error messages are truncated in Problems view #1074

HeMet opened this issue Sep 17, 2024 · 2 comments
Assignees
@matthewbastien
Labels
bug Something isn't working windows Issue specific to Windows

Comments

@HeMet
Copy link

HeMet commented Sep 17, 2024

Describe the bug
Warning and error messages are truncated in Problems view
swift_messages_truncated

To Reproduce
Steps to reproduce the behavior:

  1. Build any project with long enough warnings

Expected behavior
Warning messages should not be truncated.

Environment

  • Swift version 6.0 (swift-6.0-RELEASE)
    Target: x86_64-unknown-windows-msvc
  • Visual Studio Code version: Version: 1.93.1 (user setup)
    Commit: 38c31bc77e0dd6ae88a4e9cc93428cc27a56ba40
    Date: 2024-09-11T17:20:05.685Z
    Electron: 30.4.0
    ElectronBuildId: 10073054
    Chromium: 124.0.6367.243
    Node.js: 20.15.1
    V8: 12.4.254.20-electron.0
    OS: Windows_NT x64 10.0.22631
  • vscode-swift version: v1.11.0

Additional context
Add any other context about the problem here.
@HeMet HeMet added the bug Something isn't working label Sep 17, 2024
@plemarquand plemarquand added the windows Issue specific to Windows label Sep 17, 2024
@plemarquand
Copy link
Contributor

Thanks for this @HeMet, this definitely needs addressing. I took a quick look and this seems to be happening because these issues are parsed out of the build output, and Windows is inserting new lines at some arbitrary column length. This doesn't happen on macOS.

@award999 award999 self-assigned this Sep 18, 2024
award999 added a commit to award999/vscode-swift that referenced this issue Sep 18, 2024
@award999
Fix truncated diagnostics on Windows
1b6c21e 
* We never want to resize the terminal regardless of if
  deployed or debug environment
* If we are using conpty don't put large cols values as it
  will throw an error when task terminal opens
* When we aren't using conpty (debugging) need to set a
  large cols value

Issue: swiftlang#1074
@award999 award999 mentioned this issue Sep 18, 2024
Merged
award999 added a commit that referenced this issue Sep 19, 2024
@award999
Fix truncated diagnostics on Windows (#1082)
f527210 
* We never want to resize the terminal regardless of if
  deployed or debug environment
* If we are using conpty don't put large cols values as it
  will throw an error when task terminal opens
* When we aren't using conpty (debugging) need to set a
  large cols value

Issue: #1074
@plemarquand plemarquand added the needs verification Issue has been fixed, but requires verification before closing label Sep 20, 2024
@plemarquand
Copy link
Contributor

Verified with 2dad6d7

@award999 award999 assigned matthewbastien and unassigned award999 Sep 23, 2024
@matthewbastien matthewbastien removed their assignment Sep 23, 2024
@matthewbastien matthewbastien removed the needs verification Issue has been fixed, but requires verification before closing label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewbastien matthewbastien

Labels
bug Something isn't working windows Issue specific to Windows
Projects
Swift Extension for Visual Studio Code
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@plemarquand @HeMet @matthewbastien @award999