Skip to content

Bump ninja to 1.12.1 to fix Python 3.13 build error #78240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Bump ninja to 1.12.1 to fix Python 3.13 build error #78240

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions utils/update_checkout/update-checkout-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@
"swift-corelibs-xctest": {
"remote": { "id": "swiftlang/swift-corelibs-xctest" } },
"swift-corelibs-foundation": {
"remote": { "id": "swiftlang/swift-corelibs-foundation" } },
"remote": { "id": "swiftlang/swift-corelibs-foundation" } },
"swift-foundation-icu": {
"remote": { "id": "swiftlang/swift-foundation-icu" } },
"remote": { "id": "swiftlang/swift-foundation-icu" } },
"swift-foundation": {
"remote": { "id": "swiftlang/swift-foundation" } },
"swift-corelibs-libdispatch": {
Expand Down Expand Up @@ -149,7 +149,7 @@
"swift-corelibs-libdispatch": "main",
"swift-integration-tests": "main",
"swift-xcode-playground-support": "main",
"ninja": "v1.11.1",
"ninja": "v1.12.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a bug in 1.12+ that results in dependencies not always rebuilding correctly. I haven't been able to fully investigate, but we should not do this until we know what is happening and have a fix.

"yams": "5.1.3",
"cmake": "v3.30.2",
"indexstore-db": "main",
Expand Down Expand Up @@ -356,7 +356,7 @@
"swift-corelibs-libdispatch": "main",
"swift-integration-tests": "main",
"swift-xcode-playground-support": "main",
"ninja": "v1.11.1",
"ninja": "v1.12.1",
"yams": "5.1.3",
"cmake": "v3.30.2",
"indexstore-db": "main",
Expand Down