From 5148295c37b286d67eddf8e96bd7f0346b1ab234 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Wed, 8 Oct 2025 14:57:17 -0700 Subject: [PATCH 1/3] WiX: remove support for packaging the legacy runtime Clean up the legacy SDK packaging and remove support for it. Collapse all the various sites into the new layout only. Furthermore, rename the targets to remove the `Experimental` in the identifiers. --- platforms/Windows/Directory.Build.props | 10 +- .../Windows/SideBySideUpgradeStrategy.props | 6 +- platforms/Windows/bundle/installer.wixproj | 4 - platforms/Windows/bundle/installer.wxs | 12 - .../Windows/platforms/windows/AddDiskIds.xsl | 27 + .../Windows/platforms/windows/windows.wixproj | 26 +- .../Windows/platforms/windows/windows.wxs | 3341 +++++------------ .../Windows/rtl/legacy/lib/rtllib.wixproj | 7 - platforms/Windows/rtl/legacy/lib/rtllib.wxs | 122 - .../Windows/rtl/legacy/msi/rtlmsi.wixproj | 36 - platforms/Windows/rtl/legacy/msi/rtlmsi.wxs | 41 - .../Windows/rtl/legacy/msm/rtlmsm.wixproj | 18 - platforms/Windows/rtl/legacy/msm/rtlmsm.wxs | 20 - .../Windows/rtl/shared/lib/rtl.shared.lib.wxs | 6 +- .../Windows/rtl/shared/msi/rtl.shared.msi.wxs | 4 +- .../Windows/rtl/static/msm/rtl.static.msm.wxs | 6 +- platforms/Windows/shared/swift.en-us.wxl | 4 - 17 files changed, 909 insertions(+), 2781 deletions(-) create mode 100644 platforms/Windows/platforms/windows/AddDiskIds.xsl delete mode 100644 platforms/Windows/rtl/legacy/lib/rtllib.wixproj delete mode 100644 platforms/Windows/rtl/legacy/lib/rtllib.wxs delete mode 100644 platforms/Windows/rtl/legacy/msi/rtlmsi.wixproj delete mode 100644 platforms/Windows/rtl/legacy/msi/rtlmsi.wxs delete mode 100644 platforms/Windows/rtl/legacy/msm/rtlmsm.wixproj delete mode 100644 platforms/Windows/rtl/legacy/msm/rtlmsm.wxs diff --git a/platforms/Windows/Directory.Build.props b/platforms/Windows/Directory.Build.props index 72b72d1f..0cffdb4b 100644 --- a/platforms/Windows/Directory.Build.props +++ b/platforms/Windows/Directory.Build.props @@ -25,9 +25,6 @@ x86 - - true - $([System.IO.Path]::GetFullPath($(MSBuildThisFileDirectory)build\)) @@ -45,9 +42,10 @@ ICE38 is about mixing per-user and per-machine resources (not a thing for us). ICE61 is a warning about allowing "same-version" major upgrades, something we want. ICE64 is documented as not being an issue when packages are always per-user. + ICE71 is an error if the Media table does not contain an entry with DiskId equal to 1. ICE91 is about "roaming scenarios," which doesn't apply to our use of LocalAppDataFolder. --> - ICE38;ICE61;ICE64;ICE91 + ICE38;ICE61;ICE64;ICE71;ICE91 perUser @@ -87,10 +85,6 @@ WindowsRuntimeARM64=$(WindowsRuntimeARM64); WindowsRuntimeX64=$(WindowsRuntimeX64); WindowsRuntimeX86=$(WindowsRuntimeX86); - WindowsExperimentalRuntimeARM64=$(WindowsExperimentalRuntimeARM64); - WindowsExperimentalRuntimeX64=$(WindowsExperimentalRuntimeX64); - WindowsExperimentalRuntimeX86=$(WindowsExperimentalRuntimeX86); - IncludeLegacySDK=$(IncludeLegacySDK); diff --git a/platforms/Windows/SideBySideUpgradeStrategy.props b/platforms/Windows/SideBySideUpgradeStrategy.props index 6cf3935e..5c623546 100644 --- a/platforms/Windows/SideBySideUpgradeStrategy.props +++ b/platforms/Windows/SideBySideUpgradeStrategy.props @@ -25,8 +25,7 @@ {6F26625B-7662-4631-8E0E-F2244339ED37} {8DD91C86-D13D-490B-B06B-9522A9CF504C} {C5519168-CF7B-4127-98B7-D886D9789B42} - {BEA8C6DC-F73E-445B-9486-2333D1CF2886} - {F9BA01C7-0C7C-4898-90BD-9D6BB308F0B3} + {F9BA01C7-0C7C-4898-90BD-9D6BB308F0B3} {313B9C1F-D5B5-4FED-B7E0-138F1EE6B26A} {01AFF1CF-A025-41B6-BCBC-728D794353FD} @@ -67,8 +66,7 @@ DbgNoAssertsUpgradeCode=$(DbgNoAssertsUpgradeCode); IdeAssertsUpgradeCode=$(IdeAssertsUpgradeCode); IdeNoAssertsUpgradeCode=$(IdeNoAssertsUpgradeCode); - RtlUpgradeCode=$(RtlUpgradeCode); - ExperimentalRTLUpgradeCode=$(ExperimentalRTLUpgradeCode); + RTLUpgradeCode=$(RTLUpgradeCode); AndroidPlatformUpgradeCode=$(AndroidPlatformUpgradeCode); WindowsPlatformUpgradeCode=$(WindowsPlatformUpgradeCode); diff --git a/platforms/Windows/bundle/installer.wixproj b/platforms/Windows/bundle/installer.wixproj index 9a3d53ae..87c60ac5 100644 --- a/platforms/Windows/bundle/installer.wixproj +++ b/platforms/Windows/bundle/installer.wixproj @@ -30,10 +30,6 @@ - - - - diff --git a/platforms/Windows/bundle/installer.wxs b/platforms/Windows/bundle/installer.wxs index 194300e8..1f3e1fb0 100644 --- a/platforms/Windows/bundle/installer.wxs +++ b/platforms/Windows/bundle/installer.wxs @@ -150,21 +150,12 @@ - - - - - - - - - - diff --git a/platforms/Windows/platforms/windows/AddDiskIds.xsl b/platforms/Windows/platforms/windows/AddDiskIds.xsl new file mode 100644 index 00000000..c1ec6468 --- /dev/null +++ b/platforms/Windows/platforms/windows/AddDiskIds.xsl @@ -0,0 +1,27 @@ + + + + + + + + + + + + + + + + + + + + + 5 + + + + diff --git a/platforms/Windows/platforms/windows/windows.wixproj b/platforms/Windows/platforms/windows/windows.wixproj index 2df3ef90..0c5ee49c 100644 --- a/platforms/Windows/platforms/windows/windows.wixproj +++ b/platforms/Windows/platforms/windows/windows.wixproj @@ -3,12 +3,10 @@ windows $(ImageRoot)\Platforms\Windows.platform\Developer\SDKs\Windows.sdk\usr\lib\swift\shims - $(ImageRoot)\Platforms\Windows.platform\Developer\SDKs\WindowsExperimental.sdk\usr\lib\swift\shims $(DefineConstants); SwiftShimsPath=$(SwiftShimsPath); - ExperimentalSwiftShimsPath=$(ExperimentalSwiftShimsPath); IncludeARM64=$(WindowsArchitectures.Contains("aarch64")); IncludeX64=$(WindowsArchitectures.Contains("x86_64")); IncludeX86=$(WindowsArchitectures.Contains("i686")); @@ -20,24 +18,21 @@ - - - - + SwiftShims WindowsSDK_usr_lib_swift_shims @@ -48,14 +43,13 @@ - - - ExperimentalSwiftShims - WindowsExperimentalSDK_usr_lib_swift_shims - var.ExperimentalSwiftShimsPath - true - true - true - - + + + $(IntermediateOutputPath)_SwiftShims_dir.wxs + $(IntermediateOutputPath)_SwiftShims_dir.wxs.tmp + + + + + diff --git a/platforms/Windows/platforms/windows/windows.wxs b/platforms/Windows/platforms/windows/windows.wxs index 7fd778fd..72155e6c 100644 --- a/platforms/Windows/platforms/windows/windows.wxs +++ b/platforms/Windows/platforms/windows/windows.wxs @@ -9,38 +9,24 @@ Scope="$(PackageScope)"> - - - + - - - - - - - - - - + - - + - - + - - + @@ -68,25 +54,25 @@ - + - + - + - + - + - + @@ -99,13 +85,13 @@ - + - + - + @@ -113,15 +99,15 @@ - + - + - + - + @@ -131,83 +117,24 @@ - - - - - - + + + + + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -224,21 +151,21 @@ + - - + - + - + @@ -260,7 +187,7 @@ - + @@ -268,18 +195,18 @@ - + - + - + - + @@ -290,51 +217,51 @@ - + - + - + - + - + - + - + - + - + - + - + - + @@ -342,450 +269,306 @@ - + - + + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - + - - - + + - + - + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + - - - + + + - - - + + + - - - + + + - - - + + + - - - + + - - + + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + + - - - + + + - - - + + + - - - + + - + - + - + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - + - + - + - + - + - + - + - + - + - + @@ -793,3298 +576,2049 @@ - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - - + + + - - - + + + - - - + + + - - - + + + - - - + + + - - - + + + - - - - - - - - - + - - - + + + - - - + + + - - - + + + - - - + + - - - - + - + + + + + + + + + + + + + - - + + - - - - + - + + + + + + + + + + + + + - - + + - - - - + - + + + + + + + + + + + + + - + - + - + - + - - + + - + - + - + - - + + - + - + - + - - + + - + - + - + - - + + - + - + - + - - + + - + - + - + - - + + - - + - - - - - - + + + - - + + - - + + - - - - - - - - + + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + + - - - - - - - - - - - - - - - - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - + + - - - + + + - - + + - - + + + + + + + + + + + - - + + - + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - + - + - - + + - + - + - + - + - - + + - + - + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - + + + - - + + - - + + - - + + - - + + - - - + + + - - + + - - + + - - + + - - + + - - - + + + - - + + - - + + - - + + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - - + + - - + + + - - - - - - - - + + + - - + + - - + + + - + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - + - + - - + + - - - + + - - - - - - - - - - - - - - - - - - - - - - + - + - + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - + - + - + - + - + - + - + - + - - + - + - + - + - + - - - - - - - - - - - - - - - - - - - - - + - + - - - - - - - - - - - - - - - - - - - - @@ -4093,11 +2627,6 @@ - - - - - @@ -4106,11 +2635,6 @@ - - - - - @@ -4120,54 +2644,48 @@ - - + - - - - - - + - + - + - + - + - + - + - + - + - + - + - + @@ -4183,7 +2701,7 @@ - + @@ -4192,7 +2710,7 @@ - + @@ -4201,169 +2719,30 @@ - + - - - - - - - - + + + + + + - - + + - + - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - @@ -4423,7 +2802,7 @@ - + @@ -4432,8 +2811,8 @@ - - + + @@ -4494,7 +2873,7 @@ - + @@ -4503,8 +2882,8 @@ - - + + @@ -4565,7 +2944,7 @@ - + diff --git a/platforms/Windows/rtl/legacy/lib/rtllib.wixproj b/platforms/Windows/rtl/legacy/lib/rtllib.wixproj deleted file mode 100644 index c6ddada5..00000000 --- a/platforms/Windows/rtl/legacy/lib/rtllib.wixproj +++ /dev/null @@ -1,7 +0,0 @@ - - - rtl - Library - true - - diff --git a/platforms/Windows/rtl/legacy/lib/rtllib.wxs b/platforms/Windows/rtl/legacy/lib/rtllib.wxs deleted file mode 100644 index 88847eb6..00000000 --- a/platforms/Windows/rtl/legacy/lib/rtllib.wxs +++ /dev/null @@ -1,122 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/rtl/legacy/msi/rtlmsi.wixproj b/platforms/Windows/rtl/legacy/msi/rtlmsi.wixproj deleted file mode 100644 index 5fda9067..00000000 --- a/platforms/Windows/rtl/legacy/msi/rtlmsi.wixproj +++ /dev/null @@ -1,36 +0,0 @@ - - - rtl - - $(DefineConstants); - VCRedistDir=$(VCRedistDir); - - - - - - - - - - - - - - - - - - - - - - VCRuntime_$(ProductArchitecture) - RUNTIMEDIR_$(ProductArchitecture) - var.VCRedistDir - true - true - true - - - diff --git a/platforms/Windows/rtl/legacy/msi/rtlmsi.wxs b/platforms/Windows/rtl/legacy/msi/rtlmsi.wxs deleted file mode 100644 index e68b2dda..00000000 --- a/platforms/Windows/rtl/legacy/msi/rtlmsi.wxs +++ /dev/null @@ -1,41 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/rtl/legacy/msm/rtlmsm.wixproj b/platforms/Windows/rtl/legacy/msm/rtlmsm.wixproj deleted file mode 100644 index f36e8339..00000000 --- a/platforms/Windows/rtl/legacy/msm/rtlmsm.wixproj +++ /dev/null @@ -1,18 +0,0 @@ - - - Module - rtl.$(ProductArchitecture) - - - - - - - - - - - - - - diff --git a/platforms/Windows/rtl/legacy/msm/rtlmsm.wxs b/platforms/Windows/rtl/legacy/msm/rtlmsm.wxs deleted file mode 100644 index becee0be..00000000 --- a/platforms/Windows/rtl/legacy/msm/rtlmsm.wxs +++ /dev/null @@ -1,20 +0,0 @@ - - - - - - - - - - - - - - - - diff --git a/platforms/Windows/rtl/shared/lib/rtl.shared.lib.wxs b/platforms/Windows/rtl/shared/lib/rtl.shared.lib.wxs index a8b8e059..51b28fac 100644 --- a/platforms/Windows/rtl/shared/lib/rtl.shared.lib.wxs +++ b/platforms/Windows/rtl/shared/lib/rtl.shared.lib.wxs @@ -2,13 +2,13 @@ - + - + - + diff --git a/platforms/Windows/rtl/shared/msi/rtl.shared.msi.wxs b/platforms/Windows/rtl/shared/msi/rtl.shared.msi.wxs index a4faef3f..33b8cac5 100644 --- a/platforms/Windows/rtl/shared/msi/rtl.shared.msi.wxs +++ b/platforms/Windows/rtl/shared/msi/rtl.shared.msi.wxs @@ -3,13 +3,13 @@ Language="1033" Manufacturer="!(loc.ManufacturerName)" Name="!(loc.Rtl_ProductName_$(ProductArchitecture))" - UpgradeCode="$(ExperimentalRTLUpgradeCode)" + UpgradeCode="$(RTLUpgradeCode)" Version="$(NonSemVerProductVersion)" Scope="$(PackageScope)"> - + diff --git a/platforms/Windows/rtl/static/msm/rtl.static.msm.wxs b/platforms/Windows/rtl/static/msm/rtl.static.msm.wxs index 7654d8ff..24bc34e9 100644 --- a/platforms/Windows/rtl/static/msm/rtl.static.msm.wxs +++ b/platforms/Windows/rtl/static/msm/rtl.static.msm.wxs @@ -3,15 +3,15 @@ - + - + - + diff --git a/platforms/Windows/shared/swift.en-us.wxl b/platforms/Windows/shared/swift.en-us.wxl index fa3960f9..97592391 100644 --- a/platforms/Windows/shared/swift.en-us.wxl +++ b/platforms/Windows/shared/swift.en-us.wxl @@ -20,7 +20,6 @@ - @@ -34,9 +33,6 @@ - - - From 22e3265480b69fef19c54f1f7ba71680ca798af8 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Thu, 16 Oct 2025 16:06:47 -0700 Subject: [PATCH 2/3] WiX: adjust the Android SDK packaging This updates the android packaging to include the new experimental SDK as the default SDK. It additionally packages up the static runtime and brings the packaging layout in line with the Windows SDK packaging. It is able to sufficiently remove the dependency on the legacy SDK in the build to be useful. --- .../Windows/platforms/android/android.wxs | 2766 +++++++++++++---- platforms/Windows/shared/swift.en-us.wxl | 4 + 2 files changed, 2110 insertions(+), 660 deletions(-) diff --git a/platforms/Windows/platforms/android/android.wxs b/platforms/Windows/platforms/android/android.wxs index f460ddf4..1b123a3d 100644 --- a/platforms/Windows/platforms/android/android.wxs +++ b/platforms/Windows/platforms/android/android.wxs @@ -16,18 +16,18 @@ - + - + - + - + - + @@ -59,16 +59,16 @@ - + - + - + - + @@ -85,18 +85,18 @@ - + - + - + - + - + @@ -119,54 +119,93 @@ - - - - - + + + + + - + - - + + - - - - - - - - + + - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - + - + - + @@ -181,56 +220,56 @@ - + - + - + - + - + - + - + - + - + - + - + - + @@ -242,129 +281,130 @@ + - + + + + + + + + - + - + - + - - - - - - - - + + + + + + + + - + - + - + - - - - - - - - + + + + + + + + - + - + - + - - - - - - - - + + + + + + + + - + - + - + - - - - - - - - - + + - - + + - - + + - - + + @@ -391,73 +431,121 @@ - - + + + + + + + - - + + + + + + + - - + + + + + + + - - + + + + + + + - - + + - - + + - - + + - - + + - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - + + @@ -476,1578 +564,2743 @@ + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - - + + + + + + + + + + + + + - - + + - + - - - - + + + + + + + + + + + + + - - + + - + - - - - + + + + + + + + + + + + + - - + + - + - - - - + + + + + + + + + + + + + - + - + + + + + + - + + + + + + - + + + + + + - + + + + + + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + - + + + + + + + - + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - + - + - + - - - - + - + + + + + + + + + + + + + + + + - + - + - + - + - - - - + - + + + + + + + + + + + + + + + + - + - + - + - + - - - - + - + + + + + + + + + + + + + + + + - + - + - + - + - - - - + - + + + + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - + + + + + + + + + + + + + - + - + + + + + + + + + + + + + - + - + + + + + + + + + + + + + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + - - - - + - + + + + + + + + + + + + + - + + @@ -2056,14 +3309,15 @@ - - + + + - + - + @@ -2071,78 +3325,173 @@ - + - + - + - + - + - + - + - - - - - - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - + - - + + + + + + + - + + + - - + + + + + + + - - + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + @@ -2155,7 +3504,9 @@ + + @@ -2164,12 +3515,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - @@ -2177,17 +3557,8 @@ - - - - - - - - - - + @@ -2200,7 +3571,9 @@ + + @@ -2209,12 +3582,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - @@ -2222,17 +3624,8 @@ - - - - - - - - - - + @@ -2245,7 +3638,9 @@ + + @@ -2254,12 +3649,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - @@ -2267,17 +3691,8 @@ - - - - - - - - - - + @@ -2290,7 +3705,9 @@ + + @@ -2299,12 +3716,41 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - diff --git a/platforms/Windows/shared/swift.en-us.wxl b/platforms/Windows/shared/swift.en-us.wxl index 97592391..18792672 100644 --- a/platforms/Windows/shared/swift.en-us.wxl +++ b/platforms/Windows/shared/swift.en-us.wxl @@ -30,6 +30,10 @@ + + + + From 94c939034f8fc6ee9834251667d518d2f485b200 Mon Sep 17 00:00:00 2001 From: Saleem Abdulrasool Date: Fri, 8 Aug 2025 15:46:08 -0700 Subject: [PATCH 3/3] WiX: ingest the MSI redistributable in the toolchain With the ability to install the runtime with SxS manifesting, we now properly build the toolchain against a previous runtime which is isolated from the SDK associated runtime. In order to support this model, we must ingest the redistributable and package that into the toolchain. --- platforms/Windows/Directory.Build.props | 1 + platforms/Windows/bld/bld.wxi | 40 +++++++++---------------- platforms/Windows/bundle/installer.wxs | 3 +- 3 files changed, 17 insertions(+), 27 deletions(-) diff --git a/platforms/Windows/Directory.Build.props b/platforms/Windows/Directory.Build.props index 0cffdb4b..840e7a45 100644 --- a/platforms/Windows/Directory.Build.props +++ b/platforms/Windows/Directory.Build.props @@ -85,6 +85,7 @@ WindowsRuntimeARM64=$(WindowsRuntimeARM64); WindowsRuntimeX64=$(WindowsRuntimeX64); WindowsRuntimeX86=$(WindowsRuntimeX86); + RedistributablesDirectory=$(RedistributablesDirectory); diff --git a/platforms/Windows/bld/bld.wxi b/platforms/Windows/bld/bld.wxi index 788a543f..8140af99 100644 --- a/platforms/Windows/bld/bld.wxi +++ b/platforms/Windows/bld/bld.wxi @@ -1,6 +1,12 @@  + + + + + + + + + + @@ -212,30 +222,6 @@ - - - - - - - - - - - - - - - - - - - - - - - - @@ -551,6 +537,10 @@ + + + + @@ -558,8 +548,6 @@ - - diff --git a/platforms/Windows/bundle/installer.wxs b/platforms/Windows/bundle/installer.wxs index 1f3e1fb0..d17440e8 100644 --- a/platforms/Windows/bundle/installer.wxs +++ b/platforms/Windows/bundle/installer.wxs @@ -32,7 +32,8 @@ - + +