Skip to content

Commit 1f1cfee

Browse files
committed
Add Review Manager field to header of Swift Testing proposal template
1 parent bc5b7de commit 1f1cfee

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

proposal-templates/0000-swift-testing-template.md

+7-3
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
* Proposal: [ST-NNNN](NNNN-filename.md)
44
* Authors: [Author 1](https://github.com/author1), [Author 2](https://github.com/author2)
5+
* Review Manager: TBD
56
* Status: **Awaiting implementation** or **Awaiting review**
67
* Bug: _if applicable_ [swiftlang/swift-testing#NNNNN](https://github.com/swiftlang/swift-testing/issues/NNNNN)
78
* Implementation: [swiftlang/swift-testing#NNNNN](https://github.com/swiftlang/swift-testing/pull/NNNNN)
@@ -14,8 +15,10 @@ except for the section headers and the header fields above. For example, you
1415
should delete everything from this paragraph down to the Introduction section
1516
below.
1617

17-
As a proposal author, you should fill out all of the header fields. Delete any
18-
header fields marked _if applicable_ that are not applicable to your proposal.
18+
As a proposal author, you should fill out all of the header fields except
19+
`Review Manager`. The review manager will set that field and change several
20+
others as part of initiating the review. Delete any header fields marked _if
21+
applicable_ that are not applicable to your proposal.
1922

2023
When sharing a link to the proposal while it is still a PR, be sure to share a
2124
live link to the proposal, not an exact commit, so that readers will always see
@@ -181,4 +184,5 @@ were incorporated into the proposal as it developed, take a moment here to thank
181184
them for their contributions. This is a collaborative process, and everyone's
182185
input should receive recognition!
183186

184-
Generally, you should not acknowledge anyone who is listed as a co-author.
187+
Generally, you should not acknowledge anyone who is listed as a co-author or as
188+
the review manager.

proposals/testing/0008-exit-tests.md

+1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22

33
* Proposal: [ST-0008](https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0008-exit-tests.md)
44
* Authors: [Jonathan Grynspan](https://github.com/grynspan)
5+
* Review Manager: [Maarten Engels](https://github.com/maartene)
56
* Status: **Active Review (March 21...April 8, 2025)**
67
* Bug: [apple/swift-testing#157](https://github.com/apple/swift-testing/issues/157)
78
* Implementation: [apple/swift-testing#324](https://github.com/swiftlang/swift-testing/pull/324)

0 commit comments

Comments
 (0)