Skip to content

A lot of idling in KafkaConsumer.batchConsumerPoll #151

Closed
@blindspotbounty

Description

@blindspotbounty

After #139 we noticed that there are a lot of idling in KafkaConsumer.batchConsumerPoll

Seems that now for-loop does not exit when there is no more messages:

    private func batchConsumerPoll(
        client: RDKafkaClient,
        maxMessages: Int = 100
    ) -> [Result<KafkaConsumerMessage, Error>] {
        var messageResults = [Result<KafkaConsumerMessage, Error>]()
        messageResults.reserveCapacity(maxMessages)

        for _ in 0..<maxMessages {
            var result: Result<KafkaConsumerMessage, Error>?
            do {
                if let message = try client.consumerPoll() {
                    result = .success(message)
                }
            } catch {
                result = .failure(error)
            }

            if let result {
                messageResults.append(result)
            }                                          ///   <-------- seems we should else { return messageResults }
        }

        return messageResults
    }

Not sure if it is intended. Could you advise, please?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions