Skip to content

Commit c7343b6

Browse files
committed
fix some tests
1 parent 8d35daf commit c7343b6

File tree

4 files changed

+11
-18
lines changed

4 files changed

+11
-18
lines changed

Sources/AWSLambdaRuntime/LambdaResponseStreamWriter+Headers.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ public struct StreamingLambdaStatusAndHeadersResponse: Codable, Sendable {
4444
public init(
4545
statusCode: Int,
4646
headers: [String: String]? = nil,
47-
multiValueHeaders: [String: [String]]? = nil,
47+
multiValueHeaders: [String: [String]]? = nil
4848
) {
4949
self.statusCode = statusCode
5050
self.headers = headers

Tests/AWSLambdaRuntimeTests/LambdaResponseStreamWriter+HeadersTests.swift

Lines changed: 8 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -574,6 +574,7 @@ struct LambdaResponseStreamWriterHeadersTests {
574574
final class MockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
575575
private(set) var writtenBuffers: [ByteBuffer] = []
576576
private(set) var isFinished = false
577+
private(set) var hasCustomHeaders = false
577578

578579
func write(_ buffer: ByteBuffer) async throws {
579580
writtenBuffers.append(buffer)
@@ -589,9 +590,7 @@ final class MockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
589590
}
590591

591592
func writeCustomHeader(_ buffer: NIOCore.ByteBuffer) async throws {
592-
// This is a mock, so we don't actually write custom headers.
593-
// In a real implementation, this would handle writing custom headers.
594-
fatalError("Unexpected call to writeCustomHeader")
593+
hasCustomHeaders = true
595594
}
596595
}
597596

@@ -602,6 +601,7 @@ final class FailingMockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
602601
private(set) var writtenBuffers: [ByteBuffer] = []
603602
private(set) var writeCallCount = 0
604603
private(set) var isFinished = false
604+
private(set) var hasCustomHeaders = false
605605
private let failOnWriteCall: Int
606606

607607
init(failOnWriteCall: Int) {
@@ -628,9 +628,7 @@ final class FailingMockLambdaResponseStreamWriter: LambdaResponseStreamWriter {
628628
}
629629

630630
func writeCustomHeader(_ buffer: NIOCore.ByteBuffer) async throws {
631-
// This is a mock, so we don't actually write custom headers.
632-
// In a real implementation, this would handle writing custom headers.
633-
fatalError("Unexpected call to writeCustomHeader")
631+
hasCustomHeaders = true
634632
}
635633
}
636634

@@ -712,6 +710,7 @@ final class TrackingLambdaResponseStreamWriter: LambdaResponseStreamWriter {
712710
private(set) var finishCallCount = 0
713711
private(set) var writeAndFinishCallCount = 0
714712
private(set) var isFinished = false
713+
private(set) var hasCustomHeaders = false
715714

716715
func write(_ buffer: ByteBuffer) async throws {
717716
writeCallCount += 1
@@ -730,9 +729,7 @@ final class TrackingLambdaResponseStreamWriter: LambdaResponseStreamWriter {
730729
}
731730

732731
func writeCustomHeader(_ buffer: NIOCore.ByteBuffer) async throws {
733-
// This is a mock, so we don't actually write custom headers.
734-
// In a real implementation, this would handle writing custom headers.
735-
fatalError("Unexpected call to writeCustomHeader")
732+
hasCustomHeaders = true
736733
}
737734
}
738735

@@ -741,6 +738,7 @@ final class CustomBehaviorLambdaResponseStreamWriter: LambdaResponseStreamWriter
741738
private(set) var writtenBuffers: [ByteBuffer] = []
742739
private(set) var customBehaviorTriggered = false
743740
private(set) var isFinished = false
741+
private(set) var hasCustomHeaders = false
744742

745743
func write(_ buffer: ByteBuffer) async throws {
746744
// Trigger custom behavior on any write
@@ -759,8 +757,6 @@ final class CustomBehaviorLambdaResponseStreamWriter: LambdaResponseStreamWriter
759757
}
760758

761759
func writeCustomHeader(_ buffer: NIOCore.ByteBuffer) async throws {
762-
// This is a mock, so we don't actually write custom headers.
763-
// In a real implementation, this would handle writing custom headers.
764-
fatalError("Unexpected call to writeCustomHeader")
760+
hasCustomHeaders = true
765761
}
766762
}

Tests/AWSLambdaRuntimeTests/LambdaRuntimeClientTests.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,7 @@ struct LambdaRuntimeClientTests {
122122
}
123123
}
124124

125-
var behavior = StreamingBehavior()
125+
let behavior = StreamingBehavior()
126126
try await withMockServer(behaviour: behavior) { port in
127127
let configuration = LambdaRuntimeClient.Configuration(ip: "127.0.0.1", port: port)
128128

@@ -131,7 +131,7 @@ struct LambdaRuntimeClientTests {
131131
eventLoop: NIOSingletons.posixEventLoopGroup.next(),
132132
logger: self.logger
133133
) { runtimeClient in
134-
let (invocation, writer) = try await runtimeClient.nextInvocation()
134+
let (_, writer) = try await runtimeClient.nextInvocation()
135135

136136
// Start streaming response
137137
try await writer.write(ByteBuffer(string: "streaming"))

Tests/AWSLambdaRuntimeTests/MockLambdaClient.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,9 +47,6 @@ struct MockLambdaWriter: LambdaRuntimeClientResponseStreamWriter {
4747
}
4848

4949
func writeCustomHeader(_ buffer: NIOCore.ByteBuffer) async throws {
50-
// This is a mock, so we don't actually write custom headers.
51-
// In a real implementation, this would handle writing custom headers.
52-
fatalError("Unexpected call to writeCustomHeader")
5350
}
5451
}
5552

0 commit comments

Comments
 (0)