HTTPClient.syncShutdown() check currentEventLoop is not nil doesn't work on NIOTS

[adam-fowler]

This produces differing results between macOS and Linux

[Lukasa]

Check on current event loops on NIOTS must be willing to tolerate false negatives. If they are intended to be assertions, they should use the appropriate assert primitives.

[Lukasa]

However, the check in question uses currentEventLoop. This functionality cannot be implemented on NIOTS: it is not possible to ask what event loop you’re on. The check as provided literally cannot be duplicated, and so I think this is NTBF.

[adam-fowler]

@Lukasa is there any way for syncShutdown to check if we are running on an EventLoop when using NIOTS?

[Lukasa]

No, Dispatch provides no way to check if you are on a DispatchQueue (because the question makes no sense in the Dispatch model). The only way to make this solution 100% bulletproof is to keep a registry of all EventLoops in the program, and as EventLoop supports arbitrary conforming types we can’t even guarantee to do that.

[adam-fowler]

Ok I guess this Issue is going nowhere. Should I close?

[Lukasa]

Sorry we can’t do any better here!