Skip to content

Commit a1390f0

Browse files
committed
chore: replace container health checks with custom service readiness script in integration workflow
1 parent 3733bfb commit a1390f0

1 file changed

Lines changed: 17 additions & 12 deletions

File tree

.github/workflows/integration.yml

Lines changed: 17 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,6 @@ jobs:
2525
APP_NAME: comlink-python-integration-tests
2626
ports:
2727
- 3000:3000
28-
options: >-
29-
--health-cmd "wget --no-verbose --tries=1 -O /dev/null http://localhost:3000/readyz || exit 1"
30-
--health-interval 5s
31-
--health-timeout 10s
32-
--health-retries 10
33-
--health-start-period 15s
3428

3529
comlink-hmac:
3630
image: ghcr.io/swgoh-utils/swgoh-comlink:latest
@@ -40,14 +34,25 @@ jobs:
4034
SECRET_KEY: ${{ secrets.COMLINK_SECRET_KEY }}
4135
ports:
4236
- 3001:3000
43-
options: >-
44-
--health-cmd "wget --no-verbose --tries=1 -O /dev/null http://localhost:3000/readyz || exit 1"
45-
--health-interval 5s
46-
--health-timeout 10s
47-
--health-retries 10
48-
--health-start-period 15s
4937

5038
steps:
39+
- name: Wait for Comlink services
40+
run: |
41+
for port in 3000 3001; do
42+
echo "Waiting for service on port $port..."
43+
for i in $(seq 1 30); do
44+
if curl -sf http://localhost:$port/readyz > /dev/null 2>&1; then
45+
echo "Service on port $port is ready."
46+
break
47+
fi
48+
if [ $i -eq 30 ]; then
49+
echo "Service on port $port failed to become ready."
50+
exit 1
51+
fi
52+
sleep 2
53+
done
54+
done
55+
5156
- uses: actions/checkout@v6
5257

5358
- name: Install uv

0 commit comments

Comments
 (0)