Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of get_filters functions changed from tuple to list #1249

Open
ffourcot opened this issue Jan 14, 2025 · 2 comments
Open

Type of get_filters functions changed from tuple to list #1249

ffourcot opened this issue Jan 14, 2025 · 2 comments

Comments

@ffourcot
Copy link
Collaborator

Hello,

I think that it is a good change since a list is easier to use at this place, but old pyroute returned before a tuple:

In [3]: IPRoute().get_filters(index=0)
Out[3]: ()

Now it's a list:

In [14]: IPRoute().get_filters(index=0)
Out[14]: []

I don't know if this is done on purpose. If yes, from my point a view, a simple "breaking change" in the changelog should be enough.

@svinota
Copy link
Owner

svinota commented Jan 14, 2025

That wasn't done on purpose. Something to think about.

@svinota
Copy link
Owner

svinota commented Jan 15, 2025

@ffourcot could you tell a use case where having a mutable (list) here simplifies the things for the user comparing to immutable (tuple)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants