-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Checking for SVG.supported flag #4
Comments
Sorry for the late reply! |
I think it is necessary. If one is to use the proper method of importing depdencies via |
The thing is, that this check would be needed in every svg.js plugin which is quite a bit of an overhead. |
Hi,
I'm having an issue in my testing environment. I include
svg.js
which early on does a test for whether svg's are supported in the current environment and exits out if they are not.https://github.com/svgdotjs/svg.js/blob/04e21b18c30d546ed6a16b279504a2b58b503541/src/svg.js#L20
My issue is that
svg.js
will exit if not supported butsvg.easing.js
will not.svg.easing.js
attempts to setSVG.easing[key] = easing[key]
which fails becauseSVG.easing
does not exist.Would you accept a PR for a similar check for
SVG.supported
and exit the script the same way assvg.js
does if it's not supported?The text was updated successfully, but these errors were encountered: