Skip to content

Incompatible with Vitest 3 #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benmccann opened this issue Jan 16, 2025 · 3 comments
Closed

Incompatible with Vitest 3 #1068

benmccann opened this issue Jan 16, 2025 · 3 comments
Labels
bug Something isn't working

Comments

@benmccann
Copy link
Member

Describe the bug

Vitest seems to be using a frozen data structure for resolve conditions

Image

Reproduction URL

sveltejs/kit#13324

Reproduction

I noticed this in the renovate PR to SvelteKit for upgrading to Vitest 3

Logs

[email protected] : test packages/kit/test/prerendering/basics
  
  > [email protected] test /home/runner/work/kit/kit/packages/kit/test/prerendering/basics
  > vitest run
  
  Warning: G] Cannot find base config file "./.svelte-kit/tsconfig.json" [tsconfig.json]
  
      tsconfig.json:7:12:
        7 │   "extends": "./.svelte-kit/tsconfig.json"
          ╵              ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
  
  ⎯⎯⎯⎯⎯⎯⎯ Startup Error ⎯⎯⎯⎯⎯⎯⎯⎯
  TypeError: Cannot add property 3, object is not extensible
      at Array.push (<anonymous>)
      at configEnvironment (file:///home/runner/work/kit/kit/node_modules/.pnpm/@[email protected][email protected][email protected]_@[email protected][email protected]_/node_modules/@sveltejs/vite-plugin-svelte/src/index.js:76:31)
      at runConfigEnvironmentHook (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-BcnkIxro.js:53615:27)
      at resolveConfig (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-BcnkIxro.js:53048:9)
      at async _createServer (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vite/dist/node/chunks/dep-BcnkIxro.js:43320:18)
      at async createViteServer (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vitest/dist/chunks/cli-api.CmJw5Cd_.js:9963:18)
      at async createVitest (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vitest/dist/chunks/cli-api.CmJw5Cd_.js:13145:18)
      at async prepareVitest (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vitest/dist/chunks/cli-api.CmJw5Cd_.js:13564:15)
      at async startVitest (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vitest/dist/chunks/cli-api.CmJw5Cd_.js:13495:15)
      at async start (file:///home/runner/work/kit/kit/node_modules/.pnpm/[email protected]_@[email protected][email protected]/node_modules/vitest/dist/chunks/cac.DZC9WjGM.js:1571:17)

System Info

vitest 3
@benmccann benmccann added bug Something isn't working triage Awaiting triage by a project member labels Jan 16, 2025
@benmccann benmccann mentioned this issue Jan 16, 2025
Merged
@dominikg
Copy link
Member

cc @sheremet-va

@dominikg dominikg removed the triage Awaiting triage by a project member label Jan 16, 2025
@dominikg
Copy link
Member

repro https://github.com/dominikg/vitest-example-svelte5/tree/chore/updates

@dominikg
Copy link
Member

fixed in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benmccann @dominikg